forked from Consensys/teku
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
EIP7251 - voluntary exits operation validation (Consensys#8237)
Extended the voluntary exits validation for electra, where voluntary exits can't be processed if there are pending withdrawals in the queue. Structured this validation to be individually tested but didn't refactor the rest. also looks like a lot of the specLogic classes have heavily duplicated code but this is not really new, so I left it. partially addresses Consensys#8149 Signed-off-by: Paul Harris <paul.harris@consensys.net>
- Loading branch information
Showing
12 changed files
with
222 additions
and
22 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
63 changes: 63 additions & 0 deletions
63
...teku/spec/logic/versions/electra/operations/validation/VoluntaryExitValidatorElectra.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,63 @@ | ||
| /* | ||
| * Copyright Consensys Software Inc., 2024 | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with | ||
| * the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on | ||
| * an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the | ||
| * specific language governing permissions and limitations under the License. | ||
| */ | ||
|
|
||
| package tech.pegasys.teku.spec.logic.versions.electra.operations.validation; | ||
|
|
||
| import static tech.pegasys.teku.spec.logic.common.operations.validation.OperationInvalidReason.check; | ||
| import static tech.pegasys.teku.spec.logic.common.operations.validation.OperationInvalidReason.firstOf; | ||
|
|
||
| import com.google.common.annotations.VisibleForTesting; | ||
| import java.util.Optional; | ||
| import tech.pegasys.teku.infrastructure.unsigned.UInt64; | ||
| import tech.pegasys.teku.spec.config.SpecConfig; | ||
| import tech.pegasys.teku.spec.datastructures.operations.SignedVoluntaryExit; | ||
| import tech.pegasys.teku.spec.datastructures.state.Fork; | ||
| import tech.pegasys.teku.spec.datastructures.state.beaconstate.BeaconState; | ||
| import tech.pegasys.teku.spec.datastructures.state.beaconstate.versions.electra.BeaconStateElectra; | ||
| import tech.pegasys.teku.spec.logic.common.helpers.BeaconStateAccessors; | ||
| import tech.pegasys.teku.spec.logic.common.helpers.Predicates; | ||
| import tech.pegasys.teku.spec.logic.common.operations.validation.OperationInvalidReason; | ||
| import tech.pegasys.teku.spec.logic.versions.electra.helpers.BeaconStateAccessorsElectra; | ||
| import tech.pegasys.teku.spec.logic.versions.phase0.operations.validation.VoluntaryExitValidator; | ||
|
|
||
| public class VoluntaryExitValidatorElectra extends VoluntaryExitValidator { | ||
| private final BeaconStateAccessorsElectra stateAccessorsElectra; | ||
|
|
||
| public VoluntaryExitValidatorElectra( | ||
| final SpecConfig specConfig, | ||
| final Predicates predicates, | ||
| final BeaconStateAccessors beaconStateAccessors) { | ||
| super(specConfig, predicates, beaconStateAccessors); | ||
| this.stateAccessorsElectra = BeaconStateAccessorsElectra.required(beaconStateAccessors); | ||
| } | ||
|
|
||
| @Override | ||
| public Optional<OperationInvalidReason> validate( | ||
| final Fork fork, final BeaconState state, final SignedVoluntaryExit signedExit) { | ||
| final BeaconStateElectra stateElectra = BeaconStateElectra.required(state); | ||
| return firstOf( | ||
| () -> super.validate(fork, state, signedExit), | ||
| () -> validateElectraConditions(stateElectra, signedExit)); | ||
| } | ||
|
|
||
| @VisibleForTesting | ||
| Optional<OperationInvalidReason> validateElectraConditions( | ||
| final BeaconStateElectra stateElectra, final SignedVoluntaryExit exit) { | ||
| final int validatorId = exit.getValidatorId(); | ||
| return check( | ||
| stateAccessorsElectra | ||
| .getPendingBalanceToWithdraw(stateElectra, validatorId) | ||
| .equals(UInt64.ZERO), | ||
| VoluntaryExitValidator.ExitInvalidReason.pendingWithdrawalsInQueue()); | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.