Use correct end index for subList calls (Consensys#8271)

courtneyeh · Apr 30, 2024 · 80687ba · 80687ba
1 parent 8ddce8b
commit 80687ba
Showing 1 changed file with 4 additions and 8 deletions.
diff --git a/...pegasys/teku/spec/logic/versions/electra/statetransition/epoch/EpochProcessorElectra.java b/...pegasys/teku/spec/logic/versions/electra/statetransition/epoch/EpochProcessorElectra.java
@@ -165,8 +165,7 @@ public void processPendingBalanceDeposits(final MutableBeaconState state) {
 
     final SszList<PendingBalanceDeposit> pendingBalanceDeposits =
         stateElectra.getPendingBalanceDeposits();
-    for (int i = 0; i < pendingBalanceDeposits.size(); i++) {
-      final PendingBalanceDeposit deposit = pendingBalanceDeposits.get(i);
+    for (final PendingBalanceDeposit deposit : pendingBalanceDeposits) {
       if (processedAmount.plus(deposit.getAmount()).isGreaterThan(availableForProcessing)) {
         break;
       }
@@ -181,9 +180,7 @@ public void processPendingBalanceDeposits(final MutableBeaconState state) {
       stateElectra.setDepositBalanceToConsume(UInt64.ZERO);
     } else {
       final List<PendingBalanceDeposit> newList =
-          pendingBalanceDeposits
-              .asList()
-              .subList(nextDepositIndex, pendingBalanceDeposits.size() - 1);
+          pendingBalanceDeposits.asList().subList(nextDepositIndex, pendingBalanceDeposits.size());
       stateElectra.setPendingBalanceDeposits(
           schemaDefinitionsElectra.getPendingBalanceDepositsSchema().createFromElements(newList));
       stateElectra.setDepositBalanceToConsume(availableForProcessing.minusMinZero(processedAmount));
@@ -204,8 +201,7 @@ public void processPendingConsolidations(final MutableBeaconState state) {
         stateElectra.getPendingConsolidations();
     final UInt64 currentEpoch = stateAccessorsElectra.getCurrentEpoch(state);
 
-    for (int i = 0; i < pendingConsolidations.size(); i++) {
-      final PendingConsolidation pendingConsolidation = pendingConsolidations.get(i);
+    for (final PendingConsolidation pendingConsolidation : pendingConsolidations) {
       final Validator sourceValidator =
           state.getValidators().get(pendingConsolidation.getSourceIndex());
       if (sourceValidator.isSlashed()) {
@@ -234,7 +230,7 @@ public void processPendingConsolidations(final MutableBeaconState state) {
       final List<PendingConsolidation> newList =
           pendingConsolidations
               .asList()
-              .subList(nextPendingBalanceConsolidation, pendingConsolidations.size() - 1);
+              .subList(nextPendingBalanceConsolidation, pendingConsolidations.size());
       stateElectra.setPendingConsolidations(
           schemaDefinitionsElectra.getPendingConsolidationsSchema().createFromElements(newList));
     }