Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add bonding pool and related content types #45

Merged
merged 3 commits into from
Sep 6, 2024

Conversation

alfetopito
Copy link
Contributor

@alfetopito alfetopito commented Sep 5, 2024

Summary

Add Bonding Pool content type, as well as Solver Bonding Pool, for creating the relationships with the solvers.

image

@alfetopito alfetopito self-assigned this Sep 5, 2024
@alfetopito alfetopito requested review from bram-vdberg and a team September 5, 2024 15:04
Copy link

@bram-vdberg bram-vdberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I tried cloning the branch locally and adding a solver with bonding pool information as a test. Querying the bonding-pools endpoint lets us fetch a list of bonding pools with the information we need for the SQL query.

@alfetopito
Copy link
Contributor Author

LGTM, I tried cloning the branch locally and adding a solver with bonding pool information as a test. Querying the bonding-pools endpoint lets us fetch a list of bonding pools with the information we need for the SQL query.

Ok then, I'll bump the version and merge

Copy link

Report too large to display inline

View full report↗︎

@alfetopito alfetopito merged commit a35e7c6 into main Sep 6, 2024
3 checks passed
@alfetopito alfetopito deleted the feat/update-solver-model branch September 6, 2024 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants