Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generalize Alert Destination #33

Open
1 of 3 tasks
bh2smith opened this issue Sep 6, 2022 · 1 comment
Open
1 of 3 tasks

Generalize Alert Destination #33

bh2smith opened this issue Sep 6, 2022 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@bh2smith
Copy link
Contributor

bh2smith commented Sep 6, 2022

With Slack as the current hard-coded alert recipient, it is easy to envision a generalization where we support alternative alert destinations:

The making such a change should be similar to the abstractions used for Query monitor. Some abstract class with a method post(message) for which each different destination source has its own implementation. We may also want to have a class containing an instance of each destination and an upgrade to the Alert Levels (one for each destination class)

AlertLevel.TELEGRAM, AlertLevel.TWITTER, AlertLevel.EMAIL for which we route the posts to the appropriate place.

@bh2smith bh2smith added the enhancement New feature or request label Sep 6, 2022
@bh2smith bh2smith added the good first issue Good for newcomers label Sep 8, 2022
@bh2smith
Copy link
Contributor Author

Twitter Support introduced in #42

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant