Preemptive Refactor #15
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gentrexha
approved these changes
Aug 11, 2022
Merged
|
Closed in favour of #17 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation for a new type of Query Monitor (Counter type) we had to generalize some parts of the code to avoid duplication in the next extension class. Specifically we move slack client and dune connection into the query monitor class so that run_loop can be split into two parts (for more reusable components).
Unfortunately this mean we temporarily initialize the class with dummy versions of these classes only to set them after instantiation (this is a hack so that unit tests don't require env vars be set).
The plan is to move into something more general (although I have to do some design sketch before).
NOTE the main goal of this is to make #16 easier to read. These will be followed up with a more general refactor aimed at cleaning up the abstraction patterns and reducing redundancy.