Deactivate both cost coverage tests (#93)

Since fee data is not available anymore, both tests do not produce reasonable results. Since we might want to use modified versions of the tests, they are just removed from the daemon for now.
cowprotocol · Dec 27, 2023 · 112e35a · 112e35a
1 parent f02246f
commit 112e35a
Show file tree

Hide file tree

Showing 5 changed files with 1 addition and 197 deletions.
diff --git a/src/apis/orderbookapi.py b/src/apis/orderbookapi.py
@@ -7,7 +7,6 @@
 import json
 import requests
 from src.helper_functions import get_logger
-from src.models import Trade, OrderExecution
 from src.constants import (
     header,
     REQUEST_TIMEOUT,
@@ -58,69 +57,3 @@ def get_solver_competition_data(self, tx_hash: str) -> Optional[dict[str, Any]]:
             )
             return None
         return solver_competition_data
-
-    def get_quote(self, trade: Trade) -> Optional[Trade]:
-        """
-        Given a trade, compute buy_amount, sell_amount, and fee_amount of the trade
-        as proposed by our quoting infrastructure.
-        """
-
-        if trade.data.is_sell_order:
-            kind = "sell"
-            limit_amount_name = "sellAmountBeforeFee"
-            executed_amount = trade.execution.sell_amount
-        else:
-            kind = "buy"
-            limit_amount_name = "buyAmountAfterFee"
-            executed_amount = trade.execution.buy_amount
-
-        request_dict = {
-            "sellToken": trade.data.sell_token,
-            "buyToken": trade.data.buy_token,
-            "receiver": "0x0000000000000000000000000000000000000000",
-            "appData": "0x0000000000000000000000000000000000000000000000000000000000000000",
-            "partiallyFillable": False,
-            "sellTokenBalance": "erc20",
-            "buyTokenBalance": "erc20",
-            "from": "0x0000000000000000000000000000000000000000",
-            "priceQuality": "optimal",
-            "signingScheme": "eip712",
-            "onchainOrder": False,
-            "kind": kind,
-            limit_amount_name: str(executed_amount),
-        }
-        prod_endpoint_url = f"{PROD_BASE_URL}quote"
-
-        try:
-            quote_response = requests.post(
-                prod_endpoint_url,
-                headers=header,
-                json=request_dict,
-                timeout=REQUEST_TIMEOUT,
-            )
-        except requests.RequestException as err:
-            self.logger.warning(
-                f"Fee quote failed. Request: {request_dict}, error: {err}"
-            )
-            return None
-
-        if quote_response.status_code != SUCCESS_CODE:
-            error_response_json = json.loads(quote_response.content)
-            self.logger.warning(
-                f"Error {error_response_json['errorType']},"
-                + f"{error_response_json['description']} while getting quote for trade {trade}"
-            )
-            return None
-
-        quote_json = json.loads(quote_response.text)
-        self.logger.debug("Quote received: %s", quote_json)
-
-        quote_buy_amount = int(quote_json["quote"]["buyAmount"])
-        quote_sell_amount = int(quote_json["quote"]["sellAmount"])
-        quote_fee_amount = int(quote_json["quote"]["feeAmount"])
-
-        quote_execution = OrderExecution(
-            quote_buy_amount, quote_sell_amount, quote_fee_amount
-        )
-
-        return Trade(trade.data, quote_execution)
diff --git a/src/constants.py b/src/constants.py
@@ -13,9 +13,6 @@
 COST_COVERAGE_ABSOLUTE_DEVIATION_ETH = 0.01
 COST_COVERAGE_RELATIVE_DEVIATION = 0.50
 
-# fee quote test
-FEE_RELATIVE_DEVIATION_FLAG = 1.0
-
 # reference solver test
 SOLVER_TIME_LIMIT = 20
 

diff --git a/src/daemon.py b/src/daemon.py
@@ -12,18 +12,9 @@
 from src.monitoring_tests.solver_competition_surplus_test import (
     SolverCompetitionSurplusTest,
 )
-from src.monitoring_tests.partially_fillable_fee_quote_test import (
-    PartialFillFeeQuoteTest,
-)
-from src.monitoring_tests.partially_fillable_cost_coverage_test import (
-    PartialFillCostCoverageTest,
-)
 from src.monitoring_tests.reference_solver_surplus_test import (
     ReferenceSolverSurplusTest,
 )
-from src.monitoring_tests.cost_coverage_per_solver_test import (
-    CostCoveragePerSolverTest,
-)
 from src.monitoring_tests.mev_blocker_kickbacks_test import (
     MEVBlockerRefundsMonitoringTest,
 )
@@ -46,9 +37,6 @@ def main() -> None:
     tests = [
         SolverCompetitionSurplusTest(),
         ReferenceSolverSurplusTest(),
-        PartialFillFeeQuoteTest(),
-        PartialFillCostCoverageTest(),
-        CostCoveragePerSolverTest(),
         MEVBlockerRefundsMonitoringTest(),
         BuffersMonitoringTest(),
         CombinatorialAuctionSurplusTest(),

diff --git a/src/monitoring_tests/partially_fillable_fee_quote_test.py b/src/monitoring_tests/partially_fillable_fee_quote_test.py
diff --git a/tests/e2e/fee_test.py b/tests/e2e/fee_test.py
@@ -3,26 +3,13 @@
 """
 
 import unittest
-from src.monitoring_tests.partially_fillable_fee_quote_test import (
-    PartialFillFeeQuoteTest,
-)
+
 from src.monitoring_tests.partially_fillable_cost_coverage_test import (
     PartialFillCostCoverageTest,
 )
 
 
 class TestFees(unittest.TestCase):
-    def test_fee_quote(self):
-        fee_test = PartialFillFeeQuoteTest()
-        tx_hash = "0xf467a6a01f61fa608c1bc116e2f4f4df1b95461827b1e7700c1d36628875feab"
-        self.assertTrue(fee_test.run(tx_hash))
-        # buy order:
-        tx_hash = "0x8e9f98cabf9b6ff4e001eda5efacfd70590a60bd03a499d8b02130b67b208eb1"
-        self.assertTrue(fee_test.run(tx_hash))
-        # small executed amount:
-        tx_hash = "0xda857a0db563dae564b09febb683fff6150628c1706afc9ebd961c194ca29c5e"
-        self.assertTrue(fee_test.run(tx_hash))
-
     def test_cost_coverage(self):
         fee_test = PartialFillCostCoverageTest()
         tx_hash = "0xf467a6a01f61fa608c1bc116e2f4f4df1b95461827b1e7700c1d36628875feab"