Skip to content

Commit

Permalink
Change handling of quasimodo error (#66)
Browse files Browse the repository at this point in the history
If quasimodo does not return a valid response, instead of emitting an
error and retrying a hash, we now emit a warning and do not try the hash
again.
This is just a hotfix. To solve the underlying issue, we should
- add error handling using custom exceptions
- let tests fail gracefully by removing hashes after some retries
- find the bug in how we call quasimodo
  • Loading branch information
fhenneke authored Jul 14, 2023
1 parent 4c21a9f commit c9a5d2b
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions src/monitoring_tests/reference_solver_surplus_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -54,11 +54,11 @@ def compare_orders_surplus(

trade_alt = self.get_trade_alternative(uid, auction_instance)
if trade_alt is None:
self.logger.error(
self.logger.warning(
f"No alternative trade for uid {uid} and "
f"auction id {auction_instance['metadata']['auction_id']}"
)
return False
return True
if trade_alt.execution.buy_amount == 0:
continue

Expand Down

0 comments on commit c9a5d2b

Please sign in to comment.