Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Renaming chain_name to network #32

Open
shubhagarwal03 opened this issue Aug 15, 2024 · 0 comments
Open

Renaming chain_name to network #32

shubhagarwal03 opened this issue Aug 15, 2024 · 0 comments
Assignees
@shubhagarwal03
Labels
question Further information is requested

Comments

@shubhagarwal03
Copy link
Contributor

Throughout this repo, we currently use the CHAIN_NAME environment variable as chain_name to refer to the blockchain name.
As pointed out by Felix H, we use NETWORK as network in other cowprotocol repositories.

Does it make sense to change it?
@harisang harisang assigned harisang and shubhagarwal03 and unassigned harisang Aug 22, 2024
@fleupold fleupold added the question Further information is requested label Sep 5, 2024
@harisang harisang mentioned this issue Oct 16, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shubhagarwal03 shubhagarwal03

Labels
question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@fleupold @shubhagarwal03 @harisang