Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix missing orders #163

Merged
merged 1 commit into from
Nov 28, 2024
Merged

fix: fix missing orders #163

merged 1 commit into from
Nov 28, 2024

Conversation

anxolin
Copy link
Contributor

@anxolin anxolin commented Nov 28, 2024

Description

Context

@elena-zh create a TWAP tx that didn't get index in watch tower.
https://basescan.org/tx/0xa9e88af5dee1d51f217bbe7613e2897cec6b3d989e8f3cab5142aa74ccb96278#eventlog

I saw there was not logs for that transaction. Which is odd! I can see the event for conditional order created.
During my test, my transaction was indexed.
https://basescan.org/tx/0xf0a848e6899330e84e86160f079cf341b145b1fb2bbc2f7a8aec1dfb425384c9#eventlog

In principle both TX emit the same event, and should have been picked in the same way, but something was making us to skip some indexing of events

Cause

I reviewed the code and saw some changes applied 2 months ago were making us skip the indexing of events for some blocks.

See:
https://github.com/cowprotocol/watch-tower/pull/161/files#r1862591918

Solution

Bring back the code that skips the polling of tradable orders from the handlers, but leaves the indexing of conditional orders (so we don't miss an order creation and we can do the polling in a future block).

image

@anxolin anxolin requested review from shoom3301 and a team November 28, 2024 19:48
@anxolin
Copy link
Contributor Author

anxolin commented Nov 28, 2024

Merging asap to have it working in staging ASAP. Please @shoom3301 could you review

@anxolin anxolin merged commit 994d99d into main Nov 28, 2024
4 checks passed
@anxolin anxolin deleted the fix-missing-orders branch November 28, 2024 19:49
@github-actions github-actions bot locked and limited conversation to collaborators Nov 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant