feat: Add suspend and resume actions to watchers #2359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nono
approved these changes
Nov 5, 2024
taratatach
force-pushed
the
feat/add-suspend-resume-actions-to-watchers
branch
from
2f30015 to
1c38a40
Compare
taratatach
force-pushed
the
feat/add-suspend-resume-actions-to-watchers
branch
from
1c38a40 to
10c7343
Compare
taratatach
force-pushed
the
feat/add-suspend-resume-actions-to-watchers
branch
2 times, most recently
from
fac7c83 to
d0ddb74
Compare
When we started reacting to OS's suspend and resume events, we took the simple route of stopping and restarting both the remote and local watchers each time. However, this is time consuming, especially with the local watcher since it does a full scan of the local synchronization directory on start, and quite unnecessary since there little change we missed a local event while the computer was suspended. This is why we now introduce suspend and resume actions which, for the local watcher at least, only take care of stopping and restarting their event subscriptions. This should improve performance when resuming a suspended computer. For now the remote watcher still does a complete stop and restart as it does not trigger expensive computing.
taratatach
force-pushed
the
feat/add-suspend-resume-actions-to-watchers
branch
from
d0ddb74 to
8a31e2d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we started reacting to OS's suspend and resume events, we took
the simple route of stopping and restarting both the remote and local
watchers each time.
However, this is time consuming, especially with the local watcher
since it does a full scan of the local synchronization directory on
start, and quite unnecessary since there little change we missed a
local event while the computer was suspended.
This is why we now introduce suspend and resume actions which, for the
local watcher at least, only take care of stopping and restarting
their event subscriptions.
This should improve performance when resuming a suspended computer.
For now the remote watcher still does a complete stop and restart as
it does not trigger expensive computing.
Please make sure the following boxes are checked: