Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Vertically center updater progress spinner #2367

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

taratatach
Copy link
Member

@taratatach taratatach commented Dec 12, 2024

The spinner was slightly off, being pushed down 50% of its height.

Please make sure the following boxes are checked:

  • PR is not too big
  • it improves UX & DX in some way
  • it includes unit tests matching the implementation changes
  • it includes scenarios matching a new behaviour or has been manually tested
  • it includes relevant documentation

@taratatach taratatach self-assigned this Dec 12, 2024
@taratatach taratatach force-pushed the deps/upgrade-electron branch from d8c134c to 6df5656 Compare December 16, 2024 14:58
@taratatach taratatach force-pushed the fix/vertically-center-updater-progress-spinner branch from fb7471b to 88008b6 Compare December 17, 2024 16:24
@taratatach taratatach changed the base branch from deps/upgrade-electron to feat/add-suspend-resume-actions-to-watchers December 17, 2024 16:24
@taratatach taratatach force-pushed the feat/add-suspend-resume-actions-to-watchers branch from fac7c83 to d0ddb74 Compare December 18, 2024 11:59
@taratatach taratatach force-pushed the fix/vertically-center-updater-progress-spinner branch from 88008b6 to 2f5fe98 Compare December 18, 2024 12:01
@taratatach taratatach force-pushed the feat/add-suspend-resume-actions-to-watchers branch from d0ddb74 to 8a31e2d Compare December 18, 2024 13:08
@taratatach taratatach force-pushed the fix/vertically-center-updater-progress-spinner branch from 2f5fe98 to d0f12bd Compare December 18, 2024 13:08
Base automatically changed from feat/add-suspend-resume-actions-to-watchers to master December 18, 2024 13:09
  The spinner was slightly off, being pushed down 50% of its height.
@taratatach taratatach force-pushed the fix/vertically-center-updater-progress-spinner branch from d0f12bd to 561286f Compare December 18, 2024 13:11
@taratatach taratatach merged commit d769943 into master Dec 18, 2024
11 of 16 checks passed
@taratatach taratatach deleted the fix/vertically-center-updater-progress-spinner branch December 18, 2024 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant