feat: Check that the sourceAccountIdentifier corresponds to account name (SCR-869) #1255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clisk konnectors will now be allowed to have multiple accounts for the same konnector. To make it possible, the flagship app will allways check that the sourceAccountIdentifier returned by the konnector, corresponds to the accountName saved in the account. If there is a difference, it means that the worker webview is authenticated with the wrong account and it will ask to the konnector to authenticate again. If the a wrong sourceAccountIdentifier is return twice, an error is raised.
doubleface
force-pushed
the
feat/cliskMultiAccount
branch
from
48b25bc to
2055e10
Compare
KillianCourvoisier
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clisk konnectors will now be allowed to have multiple accounts for the
same konnector.
To make it possible, the flagship app will allways check that the
sourceAccountIdentifier returned by the konnector, corresponds to the
accountName saved in the account. If there is a difference, it means
that the worker webview is authenticated with the wrong account and it
will ask to the konnector to authenticate again.
If the a wrong sourceAccountIdentifier is return twice, an error is
raised.
Checklist
Before merging this PR, the following things must have been done if relevant: