fix: Correctly handle removal of unimportant cached files #1271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
Ldoppea
force-pushed
the
fix/prevent_offline_backup
branch
from
cd700c0 to
a015a0b
Compare
Ldoppea
force-pushed
the
feat/date_fns
branch
from
653f594 to
ac933a8
Compare
Ldoppea
force-pushed
the
fix/prevent_offline_backup
branch
from
a015a0b to
3a4ad93
Compare
Ldoppea
force-pushed
the
feat/date_fns
branch
from
ac933a8 to
5443385
Compare
Ldoppea
force-pushed
the
fix/prevent_offline_backup
branch
from
3a4ad93 to
cf951d0
Compare
Ldoppea
force-pushed
the
feat/date_fns
branch
from
5443385 to
1a3e859
Compare
zatteo
approved these changes
Jan 2, 2025
Ldoppea
force-pushed
the
fix/prevent_offline_backup
branch
from
cf951d0 to
59d2c7d
Compare
Ldoppea
force-pushed
the
fix/prevent_offline_backup
branch
from
59d2c7d to
3735581
Compare
Base automatically changed from
fix/prevent_offline_backup
to
feat/meta_offline
January 17, 2025 11:11
Previous implementation was incorrect because `lastOpened` prop was stored as a string in the device's storage and so it was retrieved as string Then the date-fns `differenceInMonths` was failing comparing dates as it accepts only `Date` objects and no string This commit fixes this by parsing the persisted date into a `Date` and by fixing related TS typings
Ldoppea
force-pushed
the
feat/date_fns
branch
from
9dfa917 to
04b4bf1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous implementation was incorrect because
lastOpenedprop was stored as a string in the device's storage and so it was retrieved as stringThen the date-fns
differenceInMonthswas failing comparing dates as it accepts onlyDateobjects and no stringThis commit fixes this by parsing the persisted date into a
Dateand by fixing related TS typings