Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/nav subscriptions #501

Merged
merged 2 commits into from
Oct 19, 2022
Merged

Feat/nav subscriptions #501

merged 2 commits into from
Oct 19, 2022

Conversation

Crash--
Copy link
Contributor

@Crash-- Crash-- commented Oct 19, 2022

Should reduce the flickering in the flagship app. 🤞

@bundlemon
Copy link

bundlemon bot commented Oct 19, 2022

BundleMon

Files updated (2)
Status Path Size Limits
app/settings.(hash).js
80.37KB (+81B +0.1%) -
intents/settings.(hash).js
41.67KB (-19B -0.04%) -
Unchanged files (14)
Status Path Size Limits
vendors/settings.(hash).js
865.13KB -
img/export-cozy-mail.(hash).svg
27.88KB -
app-settings.(hash).min.css
11.46KB -
img/import-cozy.(hash).svg
11.28KB -
img/double_authent_prez_banner.(hash).svg
4.44KB -
img/protect_data_point.(hash).svg
4.17KB -
img/niv_secu_point.(hash).svg
1.56KB -
intents-settings.(hash).min.css
1.28KB -
img/icon-bills.(hash).svg
719B -
img/icon-laptop.(hash).svg
437B -
img/icon-arrow-left.(hash).svg
419B -
img/icon-question-mark.(hash).svg
379B -
img/icon-check.(hash).svg
367B -
img/icon-phone.(hash).svg
342B -

Total files change +62B +0.01%

Groups updated (1)
Status Path Size Limits
**/*.js
987.16KB (+62B +0.01%) +5%
Unchanged groups (2)
Status Path Size Limits
img/.
51.93KB +5%
**/*.css
42.79KB +5%

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

src/hooks/useOffersLink.ts Outdated Show resolved Hide resolved
We can run the both queries in parallel in order to make them faster.
Also, I added a very long fetch policy since this information is not
something we change often. This is something we can persist.

I changed query by client.fetchQueryAndGetFromState() because of
cozy/cozy-client#931
@Crash-- Crash-- force-pushed the feat/NavSubscriptions branch from 24be85a to 97d0bbb Compare October 19, 2022 14:37
@Crash-- Crash-- merged commit 4255467 into master Oct 19, 2022
@Crash-- Crash-- deleted the feat/NavSubscriptions branch October 19, 2022 14:51
@cozy cozy deleted a comment from cozy-bot Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants