Add cache for the Swift AppFS #4178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When loading html, js, css, and images for a webapp or a konnector, the stack makes a call to the AppFS server. With many users and a Swift cluster, we can improve latency by using a cache.
taratatach
approved these changes
Oct 23, 2023
| // NewSwiftFileServer returns provides the apps.FileServer implementation | ||
| // using the swift backend as file server. | ||
| func NewSwiftFileServer(conn *swift.Connection, appsType consts.AppType) FileServer { | ||
| initCacheOnce.Do(func() { | ||
| c, err := lru.New[string, cacheEntry](128) |
There was a problem hiding this comment.
Why such a small cache? Don't we have more konnectors and applications already?
There was a problem hiding this comment.
Well, it can take a lot of RAM. I prefer to start small and see later to increase.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When loading html, js, css, and images for a webapp or a konnector, the stack makes a call to the AppFS server. With many users and a Swift cluster, we can improve latency by using a cache.