Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Send a push notification for sharing shortcuts #4495

Merged
merged 2 commits into from
Jan 2, 2025
Merged

Send a push notification for sharing shortcuts #4495

merged 2 commits into from
Jan 2, 2025

Conversation

nono
Copy link
Member

@nono nono commented Nov 25, 2024

No description provided.

@nono nono requested a review from Merkur39 November 25, 2024 14:49
@zatteo
Copy link
Contributor

zatteo commented Jan 2, 2025

👍

image

zatteo
zatteo reviewed Jan 2, 2025
View reviewed changes
model/sharing/invitation.go Outdated
if err != nil {
return err
}
hasFlashship := false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hasFlashship -> hasFlagship

@nono nono force-pushed the sharing-push-notification branch from 9cf976a to a374ea4 Compare January 2, 2025 11:26
@nono nono marked this pull request as ready for review January 2, 2025 11:26
@nono nono requested a review from a team as a code owner January 2, 2025 11:26
@nono nono merged commit e3b7ee5 into master Jan 2, 2025
4 checks passed
@nono nono deleted the sharing-push-notification branch January 2, 2025 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zatteo zatteo zatteo approved these changes

@Merkur39 Merkur39 Awaiting requested review from Merkur39

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nono @zatteo