-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add deepCSV SFs #270
add deepCSV SFs #270
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks !
Let's wait for the other PR to be merged to factorize the changes to the reference trees, but it looks good
382117f
to
0787ee8
Compare
https://github.com/cp3-llbb/Framework/pull/270/files#diff-a1ce3e72a6655012c2f076271533f7c3R104 |
tracked at #257 |
0787ee8
to
0e2594e
Compare
I think we are ready to go :) |
please test |
Thanks! the tests outputs are as expected (see below), can you update the corresponding reference trees ?
|
Thanks! |
Adding Scale Factors for DeepCSV