Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for ESP32-C3 #111

Merged
merged 1 commit into from
Aug 8, 2024
Merged

Add support for ESP32-C3 #111

merged 1 commit into from
Aug 8, 2024

Conversation

tjfsteele
Copy link
Contributor

No description provided.

@tjfsteele
Copy link
Contributor Author

There is also one change needed to esp async webserver (separate lib) due to a compile error with ambigious overload:

return IPAddress(0U); -> return IPAddress((uint32_t)0);

@DaveDavenport
Copy link

relevant issue: me-no-dev/ESPAsyncWebServer#1164

@cpainchaud
Copy link
Owner

Can you please also make the change for the IPAddress(0U) code? and test it will still compile with other targets?
Then I will merge your request happily!

@cpainchaud
Copy link
Owner

You will also need to enable builds in .travis.platform.ini and add steps in the GitHub Actions (.github/workflows) so they get built automatically

@tjfsteele
Copy link
Contributor Author

Can you please also make the change for the IPAddress(0U) code? and test it will still compile with other targets? Then I will merge your request happily!

The other change is in a different Git repository, it's already been requested.

@tjfsteele
Copy link
Contributor Author

If you can send me your postal address we would like to send you a pcb for RFlink32

@cpainchaud
Copy link
Owner

@tjfsteele me?

@tjfsteele
Copy link
Contributor Author

@tjfsteele me?

@cpainchaud Yes :)

@tjfsteele
Copy link
Contributor Author

@cpainchaud My email address is nodo@tjfs.com

@cpainchaud cpainchaud merged commit 9641576 into cpainchaud:master Aug 8, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants