Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Use repetition time from BIDS metadata instead of nifti header #218

Merged
merged 1 commit into from
Aug 5, 2024

Conversation

Remi-Gau
Copy link
Contributor

@Remi-Gau Remi-Gau commented Aug 5, 2024

Copy link

codecov bot commented Aug 5, 2024

Codecov Report

Attention: Patch coverage is 48.14815% with 14 lines in your changes missing coverage. Please review.

Project coverage is 82.34%. Comparing base (1bcca23) to head (8a61d89).
Report is 102 commits behind head on main.

Files with missing lines Patch % Lines
bidsmreye/prepare_data.py 10.00% 9 Missing ⚠️
bidsmreye/generalize.py 0.00% 4 Missing ⚠️
bidsmreye/bids_utils.py 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #218      +/-   ##
==========================================
+ Coverage   79.91%   82.34%   +2.43%     
==========================================
  Files          13       15       +2     
  Lines         926      946      +20     
  Branches      119        0     -119     
==========================================
+ Hits          740      779      +39     
- Misses        144      167      +23     
+ Partials       42        0      -42     
Flag Coverage Δ
tests 82.34% <48.14%> (+2.54%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Remi-Gau Remi-Gau changed the title [FIX] Use repetition time from BIDS metadata instead of niftiheader [FIX] Use repetition time from BIDS metadata instead of nifti header Aug 5, 2024
@Remi-Gau Remi-Gau marked this pull request as ready for review August 5, 2024 14:56
Copy link

sourcery-ai bot commented Aug 5, 2024

🧙 Sourcery has finished reviewing your pull request!


Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • Continue your discussion with Sourcery by replying directly to review comments.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've reviewed this pull request using the Sourcery rules engine. If you would also like our AI-powered code review then let us know.

@Remi-Gau Remi-Gau merged commit 8cf6133 into cpp-lln-lab:main Aug 5, 2024
11 of 12 checks passed
@Remi-Gau Remi-Gau deleted the fix/201 branch August 12, 2024 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ZeroDivisionError: float division by zero when trying to create sidecar
1 participant