-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] do not apply run found for one task to all tasks #228
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #228 +/- ##
==========================================
+ Coverage 79.91% 82.14% +2.22%
==========================================
Files 13 15 +2
Lines 926 952 +26
Branches 119 0 -119
==========================================
+ Hits 740 782 +42
- Misses 144 170 +26
+ Partials 42 0 -42
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
🧙 Sourcery has finished reviewing your pull request! Tips
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We've reviewed this pull request using the Sourcery rules engine. If you would also like our AI-powered code review then let us know.
in dataset with multiple tasks, if a task 'foo' has runs (say from 1 to 10) but another task 'bar' does not, the config was set to look for runs 1 to 10 in all tasks and would return no file for task 'bar' when preparing / generalysing data.