Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] do not apply run found for one task to all tasks #228

Merged
merged 6 commits into from
Aug 10, 2024

Conversation

Remi-Gau
Copy link
Contributor

@Remi-Gau Remi-Gau commented Aug 10, 2024

in dataset with multiple tasks, if a task 'foo' has runs (say from 1 to 10) but another task 'bar' does not, the config was set to look for runs 1 to 10 in all tasks and would return no file for task 'bar' when preparing / generalysing data.

@Remi-Gau Remi-Gau changed the title FIX[] fix not finding tasks when another task has a run entity [FIX] do not apply run found for one task to all tasks Aug 10, 2024
Copy link

codecov bot commented Aug 10, 2024

Codecov Report

Attention: Patch coverage is 88.88889% with 1 line in your changes missing coverage. Please review.

Project coverage is 82.14%. Comparing base (1bcca23) to head (ca9af5f).
Report is 103 commits behind head on main.

Files with missing lines Patch % Lines
bidsmreye/bids_utils.py 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #228      +/-   ##
==========================================
+ Coverage   79.91%   82.14%   +2.22%     
==========================================
  Files          13       15       +2     
  Lines         926      952      +26     
  Branches      119        0     -119     
==========================================
+ Hits          740      782      +42     
- Misses        144      170      +26     
+ Partials       42        0      -42     
Flag Coverage Δ
tests 82.14% <88.88%> (+2.33%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Remi-Gau Remi-Gau marked this pull request as ready for review August 10, 2024 10:28
Copy link

sourcery-ai bot commented Aug 10, 2024

🧙 Sourcery has finished reviewing your pull request!


Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • Continue your discussion with Sourcery by replying directly to review comments.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've reviewed this pull request using the Sourcery rules engine. If you would also like our AI-powered code review then let us know.

@Remi-Gau Remi-Gau merged commit f04cb24 into cpp-lln-lab:main Aug 10, 2024
13 checks passed
@Remi-Gau Remi-Gau deleted the fix/212 branch August 12, 2024 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bidsmreye process only one task in the bids_dir
1 participant