Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] save onsets.mat directly in subject stats folder #1187

Merged
merged 3 commits into from
Jan 25, 2024

Conversation

Remi-Gau
Copy link
Contributor

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Type: Bug fix

PR Summary: The pull request addresses an issue where the 'onsets.mat' file was not being saved in the correct directory. The changes ensure that the file is now directly saved in the subject stats folder, which resolves the problem reported in issue #1185.

Decision: Comment

📝 Type: 'Bug fix' - not supported yet.
  • Sourcery currently only approves 'Typo fix' PRs.
✅ Issue addressed: this change correctly addresses the issue or implements the desired feature.
No details provided.
📝 Complexity: the changes are too large or complex for Sourcery to approve.
  • Unsupported files: the diff contains files that Sourcery does not currently support during reviews.

General suggestions:

  • Ensure that the new file path is robustly constructed to handle different operating systems and edge cases.
  • Consider adding a brief comment in the code explaining why the file path was changed, for future reference.

Thanks for using Sourcery. We offer it for free for open source projects and would be very grateful if you could help us grow. If you like it, would you consider sharing Sourcery on your favourite social media? ✨

Share Sourcery

Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

@Remi-Gau Remi-Gau merged commit 55e975d into cpp-lln-lab:main Jan 25, 2024
26 of 28 checks passed
@Remi-Gau Remi-Gau deleted the 1185 branch January 25, 2024 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Cannot set raw data to read only when running docker container
1 participant