Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[STY] use isort #1198

Merged
merged 1 commit into from
Feb 5, 2024
Merged

[STY] use isort #1198

merged 1 commit into from
Feb 5, 2024

Conversation

Remi-Gau
Copy link
Contributor

@Remi-Gau Remi-Gau commented Feb 5, 2024

No description provided.

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Type: Refactoring

PR Summary: This pull request focuses on improving the project's code style by integrating isort for consistent import ordering, aligned with black formatting. It includes the addition of isort to the pre-commit configuration, removal of a previous import ordering tool, and refactoring of import statements across several Python files to consolidate imports from the same module into a single line. These changes are spread across the project's configuration files and Python source files, including demo scripts and tests.

Decision: Comment

📝 Type: 'Refactoring' - not supported yet.
  • Sourcery currently only approves 'Typo fix' PRs.
✅ Issue addressed: this change correctly addresses the issue or implements the desired feature.
No details provided.
✅ Small diff: the diff is small enough to approve with confidence.
No details provided.

General suggestions:

  • Ensure that the integration of isort and the removal of the previous import ordering tool (reorder-python-imports) are clearly communicated to the team. This helps in maintaining consistency in future contributions.
  • Review the consolidated import statements to ensure they adhere to the project's line length standards and do not introduce any readability issues.
  • Consider running a full project build and test suite to verify that these stylistic changes do not inadvertently affect the functionality.

Thanks for using Sourcery. We offer it for free for open source projects and would be very grateful if you could help us grow. If you like it, would you consider sharing Sourcery on your favourite social media? ✨

Share Sourcery

Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

@Remi-Gau Remi-Gau merged commit 97e6384 into cpp-lln-lab:main Feb 5, 2024
25 of 27 checks passed
@Remi-Gau Remi-Gau deleted the sty branch February 5, 2024 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant