Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] make addConfoundsToDesignMatrix a method of BidsModel #1294

Merged
merged 2 commits into from
Jul 24, 2024

Conversation

Remi-Gau
Copy link
Contributor

@Remi-Gau Remi-Gau marked this pull request as ready for review July 24, 2024 06:41
Copy link

codecov bot commented Jul 24, 2024

Codecov Report

Attention: Patch coverage is 94.20290% with 4 lines in your changes missing coverage. Please review.

Project coverage is 77.84%. Comparing base (f53979a) to head (24e20ff).
Report is 135 commits behind head on main.

Files with missing lines Patch % Lines
src/bids_model/BidsModel.m 94.02% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1294      +/-   ##
==========================================
- Coverage   79.57%   77.84%   -1.74%     
==========================================
  Files         285      290       +5     
  Lines        7742     7899     +157     
  Branches       40       50      +10     
==========================================
- Hits         6161     6149      -12     
- Misses       1565     1750     +185     
+ Partials       16        0      -16     
Flag Coverage Δ
cli 0.00% <ø> (-39.00%) ⬇️
macos-13_matlab-R2023b_fast 60.49% <94.20%> (?)
macos-13_matlab-R2023b_slow 58.40% <0.00%> (?)
macos-latest_matlab-R2023a_fast ?
macos-latest_matlab-R2023a_slow ?
octave 76.43% <89.85%> (+0.71%) ⬆️
ubuntu-latest_matlab-R2023a_fast ?
ubuntu-latest_matlab-R2023a_slow ?
ubuntu-latest_matlab-R2023b_fast 60.49% <94.20%> (?)
ubuntu-latest_matlab-R2023b_slow 58.39% <0.00%> (?)
windows-latest_matlab-R2023b_fast 60.49% <94.20%> (?)
windows-latest_matlab-R2023b_slow 58.40% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

sourcery-ai bot commented Jul 24, 2024

🧙 Sourcery has finished reviewing your pull request!


Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • Continue your discussion with Sourcery by replying directly to review comments.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've reviewed this pull request using the Sourcery rules engine. If you would also like our AI-powered code review then let us know.

@Remi-Gau Remi-Gau changed the title [ENH] make add confound stratefy a method [ENH] make add confound strategy a method Jul 24, 2024
@Remi-Gau Remi-Gau changed the title [ENH] make add confound strategy a method [ENH] make addConfoundsToDesignMatrix a method of BidsModel Jul 24, 2024
@Remi-Gau Remi-Gau merged commit 344838e into cpp-lln-lab:main Jul 24, 2024
33 of 35 checks passed
@Remi-Gau Remi-Gau deleted the enh/1286 branch July 24, 2024 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add load confounds options to create default model action and cli
1 participant