Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] implement one-way ANOVA at group level to compare groups #1296

Merged
merged 34 commits into from
Jul 30, 2024

Conversation

Remi-Gau
Copy link
Contributor

@Remi-Gau Remi-Gau commented Jul 24, 2024


  • implement F contrasts

* start adding sub commands

* preproc subcommand

* deal with create roi parser

* deal with default_model sub command

* deal with bms action

* deal with stats actions

* start adapting cli

* add test for command building

* add test for CLI for preproc, smooth...

* add test for command building for stats

* add test for command building for bms

* rename function

* start switching CLI

* several fixes

* more fix

* keep switchingµ

* fix

* fix

* linti

* fixes

* fixes

* minor fixes

* additional fixes

* fix output ROI

* visualize output in circle ci
Copy link

codecov bot commented Jul 24, 2024

Codecov Report

Attention: Patch coverage is 90.78212% with 33 lines in your changes missing coverage. Please review.

Project coverage is 81.62%. Comparing base (f53979a) to head (f84cbb3).
Report is 135 commits behind head on main.

Files with missing lines Patch % Lines
src/bids_model/BidsModel.m 82.60% 12 Missing ⚠️
src/batches/stats/setBatchFactorialDesign.m 93.44% 8 Missing ⚠️
src/bids/getAvailableGroups.m 81.81% 2 Missing ⚠️
...rc/bids_model/getContrastsListForFactorialDesign.m 81.81% 2 Missing ⚠️
src/stats/subject_level/specifyContrasts.m 84.61% 2 Missing ⚠️
src/stats/utils/checkSpmMat.m 81.81% 2 Missing ⚠️
src/workflows/stats/bidsResults.m 90.90% 2 Missing ⚠️
src/bids_model/getInclusiveMask.m 75.00% 1 Missing ⚠️
src/stats/utils/getContrastNb.m 0.00% 1 Missing ⚠️
src/workflows/stats/bidsFFX.m 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1296      +/-   ##
==========================================
+ Coverage   79.57%   81.62%   +2.04%     
==========================================
  Files         285      282       -3     
  Lines        7742     7667      -75     
  Branches       40        0      -40     
==========================================
+ Hits         6161     6258      +97     
+ Misses       1565     1409     -156     
+ Partials       16        0      -16     
Flag Coverage Δ
cli ?
macos-13_matlab-R2023b_fast 64.17% <69.27%> (?)
macos-13_matlab-R2023b_slow 58.38% <74.02%> (?)
macos-latest_matlab-R2023a_fast ?
macos-latest_matlab-R2023a_slow ?
octave 76.37% <81.84%> (+0.66%) ⬆️
ubuntu-latest_matlab-R2023a_fast ?
ubuntu-latest_matlab-R2023a_slow ?
ubuntu-latest_matlab-R2023b_fast 64.17% <69.27%> (?)
ubuntu-latest_matlab-R2023b_slow 58.36% <74.02%> (?)
windows-latest_matlab-R2023b_fast 64.17% <69.27%> (?)
windows-latest_matlab-R2023b_slow 58.38% <74.02%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Remi-Gau Remi-Gau changed the title Enh/1229 [ENH] implement one-way ANOVA at group level to compare groups Jul 25, 2024
@Remi-Gau Remi-Gau marked this pull request as ready for review July 30, 2024 12:52
Copy link
Contributor

sourcery-ai bot commented Jul 30, 2024

🧙 Sourcery has finished reviewing your pull request!


Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • Continue your discussion with Sourcery by replying directly to review comments.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've reviewed this pull request using the Sourcery rules engine. If you would also like our AI-powered code review then let us know.

@Remi-Gau Remi-Gau mentioned this pull request Jul 30, 2024
@Remi-Gau Remi-Gau merged commit 64b14da into cpp-lln-lab:main Jul 30, 2024
19 of 21 checks passed
@Remi-Gau Remi-Gau deleted the enh/1229 branch July 30, 2024 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bidspm with 3 groups
1 participant