Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] add boutiques descriptor #1302

Merged
merged 3 commits into from
Aug 6, 2024
Merged

Conversation

Remi-Gau
Copy link
Contributor

@Remi-Gau Remi-Gau commented Aug 6, 2024

closes #1270

Copy link

codecov bot commented Aug 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.66%. Comparing base (f53979a) to head (206eb5a).
Report is 141 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (f53979a) and HEAD (206eb5a). Click for more details.

HEAD has 6 uploads less than BASE
Flag BASE (f53979a) HEAD (206eb5a)
cli 1 0
ubuntu-latest_matlab-R2023a_fast 1 0
octave 2 1
ubuntu-latest_matlab-R2023a_slow 1 0
macos-latest_matlab-R2023a_fast 1 0
macos-latest_matlab-R2023a_slow 1 0
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1302       +/-   ##
===========================================
- Coverage   79.57%   59.66%   -19.92%     
===========================================
  Files         285      284        -1     
  Lines        7742     7745        +3     
  Branches       40        0       -40     
===========================================
- Hits         6161     4621     -1540     
- Misses       1565     3124     +1559     
+ Partials       16        0       -16     
Flag Coverage Δ
cli ?
macos-13_matlab-R2023b_slow 58.67% <ø> (?)
macos-latest_matlab-R2023a_fast ?
macos-latest_matlab-R2023a_slow ?
octave 53.80% <ø> (-21.92%) ⬇️
ubuntu-latest_matlab-R2023a_fast ?
ubuntu-latest_matlab-R2023a_slow ?
ubuntu-latest_matlab-R2023b_slow 59.16% <ø> (?)
windows-latest_matlab-R2023b_slow 58.67% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Remi-Gau Remi-Gau marked this pull request as ready for review August 6, 2024 14:07
Copy link
Contributor

sourcery-ai bot commented Aug 6, 2024

🧙 Sourcery has finished reviewing your pull request!


Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • Continue your discussion with Sourcery by replying directly to review comments.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've reviewed this pull request using the Sourcery rules engine. If you would also like our AI-powered code review then let us know.

@Remi-Gau Remi-Gau merged commit 5b88310 into cpp-lln-lab:main Aug 6, 2024
18 of 36 checks passed
@Remi-Gau Remi-Gau deleted the enh/boutiques branch August 17, 2024 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add boutiques descriptors
1 participant