Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fullscreen permissions #453

Merged
merged 1 commit into from
Jul 17, 2023
Merged

fix: fullscreen permissions #453

merged 1 commit into from
Jul 17, 2023

Conversation

cpvalente
Copy link
Owner

attempt fixing issues with going fullscreen by configuring the Content Security Policy

attempt fixing issues with going fullscreen by configuring the Content Security Policy
@cpvalente
Copy link
Owner Author

Hey @asharonbaltazar, I know this is a long stretch, but maybe worth a shot

We get some unhandled errors in sentry relating to the fullscreen option in the views

TypeError toggleFullScreen(src/common/hooks/useFullscreen)
Disallowed by permissions policy

the line in question is the request to go fullscreen
https://github.com/cpvalente/ontime/blob/master/apps/client/src/common/hooks/useFullscreen.ts#L39

From a quick google it seems that we can resolve this by configuring the Content Policy in the meta attributes.
Do you have experience with this? Or at least know how I can recreate the issue myself?

@cpvalente cpvalente merged commit 4a0d83d into master Jul 17, 2023
2 checks passed
@cpvalente cpvalente deleted the fix-fullscreen branch July 17, 2023 11:51
@asharonbaltazar
Copy link
Collaborator

Sorry for the late response, but I don't have experience with this :/

@cpvalente
Copy link
Owner Author

No worries @asharonbaltazar, it was worth a shot.
Took a look at some other code that I maintain and I don't handle this anywhere else. Strange that sentry logs so many errors with this. Maybe Ontime users use operating systems that are more tightly monitored or use performance apps that prevent this. I myself used to use caffeine in conjunction with a bunch of apple scripts to keep things running
Interesting stuff

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants