Enhances method for retrieving task statuses in the CambAI class
#2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Consolidated `get_dubbing_task_status` and `get_tts_task_status` into `get_task_status`. - Added support for "tts", "dubbing", and "transcription" tasks in get_task_status. - Updated method calls to use `get_task_status` with appropriate task type.
- Added a check to raise ValueError for invalid task types. - Ensured URL is initialized before assignment based on task type. - Removed redundant comments and improved readability.
- Updated docstring for `get_task_status` to include all task types. - Added a check to raise ValueError for invalid task types. - Improved URL initialization and assignment logic. - Enhanced readability by consolidating error checks.
- Replaced `get_dubbing_task_status` with ` for TTS task.
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors and enhances the method for retrieving task statuses in the CambAI class. The changes consolidate the methods for getting the status of various tasks (dubbing, TTS, transcription) into a single method,
get_task_status, which improves code maintainability and readability.get_dubbing_task_statusandget_tts_task_statuswith a singleget_task_statusmethod.get_task_statusmethod now handles three types of tasks:dubbing,tts, andtranscription.