Add pooler personality configuration on pgbouncer.ini template #29
Conversation
| @@ -8,7 +8,14 @@ nodeAffinity: {} # optionally define nodeAffinity | |||
| tolerations: [] # optionally define tolerations | |||
| nodeSelector: {} # optionally define nodeSelector | |||
|
|
|||
| poolMode: session | |||
There was a problem hiding this comment.
could you leave the poolMode=session line - but comment it out and add comment? e.g.,
# poolMode: session # please use poolerPersonality.poolMode
There was a problem hiding this comment.
Nice idea will do it like that
There was a problem hiding this comment.
@angeloskyratzakos it's been a while - sorry! it would be great to get your changes in. could you make this last change - to re-add the poolMode line but commented out?
pgbouncer/values.yaml
Outdated
| # serverResetQuery: "DISCARD ALL" | ||
| # serverResetQueryAlways: 0 | ||
| # ignoreStartupParameters: "" | ||
| # serverCheckQuery: "SELECT 1;" |
There was a problem hiding this comment.
the default in pgbouncer_1_8_1 is select 1. why did you change it?
There was a problem hiding this comment.
You are right. I was following the pgbouncer's config
| server_reset_query = {{ .Values.poolerPersonality.serverResetQuery | default "DISCARD ALL" }} | ||
| server_reset_query_always = {{ .Values.poolerPersonality.serverResetQueryAlways | default 0 }} | ||
| ignore_startup_parameters = {{ .Values.poolerPersonality.ignoreStartupParameters | default "" }} | ||
| server_check_query = {{ .Values.poolerPersonality.serverCheckQuery | default "SELECT 1;" }} |
There was a problem hiding this comment.
the default in pgbouncer_1_8_1 is select 1. why did you change it?
There was a problem hiding this comment.
You're right, I will update it. I was following pgbouncer's config page
| ;server_check_query = select 1 | ||
| ;server_check_delay = 30 | ||
| ;application_name_add_host = 0 | ||
| pool_mode = {{ .Values.poolerPersonality.poolMode | default "session" }} |
There was a problem hiding this comment.
in order to preserve backwards compatibility for chart users that may be doing custom overrides (through a -f overrides.yaml file or by pulling in pgbouncer as a requirements chart), i recommend changing this to use .Values.poolMode if it is in the dictionary. could you change this line to
pool_mode = {{ .Values.poolMode | default .Values.poolerPersonality.poolMode | default "session" }}
There was a problem hiding this comment.
Nice trick! I didn't know that one. Thanks for the suggestion!
|
|
||
| connectionLimits: | ||
| maxClientConn: 200 | ||
| defaultPoolSize: 200 | ||
| minPoolSize: 15 | ||
| reservePoolSize: 25 | ||
| reservePoolTimeout: 5 | ||
| # maxDbConnections: 0 # zero means unlimited | ||
| # maxUserConnections: 0 # zero means unlimited |
There was a problem hiding this comment.
same as above (since you didn't add templating for max_user_connections)
There was a problem hiding this comment.
I have added for it as well please check line 81
There was a problem hiding this comment.
@matth-boise Thank you very much for your time spending on my PR, appreciate it. I'm sorry for the delay, I will push the fixes right now.
| @@ -8,7 +8,14 @@ nodeAffinity: {} # optionally define nodeAffinity | |||
| tolerations: [] # optionally define tolerations | |||
| nodeSelector: {} # optionally define nodeSelector | |||
|
|
|||
| poolMode: session | |||
There was a problem hiding this comment.
Nice idea will do it like that
pgbouncer/values.yaml
Outdated
| # serverResetQuery: "DISCARD ALL" | ||
| # serverResetQueryAlways: 0 | ||
| # ignoreStartupParameters: "" | ||
| # serverCheckQuery: "SELECT 1;" |
There was a problem hiding this comment.
You are right. I was following the pgbouncer's config
|
|
||
| connectionLimits: | ||
| maxClientConn: 200 | ||
| defaultPoolSize: 200 | ||
| minPoolSize: 15 | ||
| reservePoolSize: 25 | ||
| reservePoolTimeout: 5 | ||
| # maxDbConnections: 0 # zero means unlimited | ||
| # maxUserConnections: 0 # zero means unlimited |
There was a problem hiding this comment.
I have added for it as well please check line 81
| server_reset_query = {{ .Values.poolerPersonality.serverResetQuery | default "DISCARD ALL" }} | ||
| server_reset_query_always = {{ .Values.poolerPersonality.serverResetQueryAlways | default 0 }} | ||
| ignore_startup_parameters = {{ .Values.poolerPersonality.ignoreStartupParameters | default "" }} | ||
| server_check_query = {{ .Values.poolerPersonality.serverCheckQuery | default "SELECT 1;" }} |
There was a problem hiding this comment.
You're right, I will update it. I was following pgbouncer's config page
| ;server_check_query = select 1 | ||
| ;server_check_delay = 30 | ||
| ;application_name_add_host = 0 | ||
| pool_mode = {{ .Values.poolerPersonality.poolMode | default "session" }} |
There was a problem hiding this comment.
Nice trick! I didn't know that one. Thanks for the suggestion!
Enabling some of the pooler configuration parameters.
I have also added
poolModeunder thepoolerPersonality, so this might be a breaking change.I can leave it as is, if there is any issue.
Thanks