Unify and improve FromHex in ColorHelper.cs and ColorExtensions.cs #961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Both now use ColorHelper.FromHex, rather than differing implementations * FromHex now accepts hex numbers with three and four digits matching HTML color codes, where "ABC" maps to "AABBCC" * Significant performance increase using bitshifts over string operations
|
Thanks @Eb3yr. Side note: Looking at it, I'm not sure why there are two separate classes related to color utilities. This is something that needs to be looked into and cleaned up as well. Going to open an issue for it to track that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated ColorExtensions.FromHex to reference ColorHelper.FromHex rather than using it's own, different, implementation.
Updated ColorHelper.FromHex with a new implementation that makes use of a single uint parse of the hex code and bit shifts, rather than numerous string operations, which is approx. 4x faster. It now also supports conversions of 3-and-4 digit hex codes in the same manner as HTML color codes, where "ABC" would be interpreted as "AABBCC".