Skip to content

Commit

Permalink
For reasons size="small" isn't inheriting down to the table cells so …
Browse files Browse the repository at this point in the history
…setting it on the cells explicitly
  • Loading branch information
craigatk committed Jan 8, 2020
1 parent 3890481 commit f54b90c
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 6 deletions.
3 changes: 3 additions & 0 deletions ui/src/TestCase/list/TestCaseListRow.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ const TestCaseListRow = ({
key="test-result-cell"
role="rowcell"
data-testid={`test-case-result-${testCase.testSuiteIdx}-${testCase.idx}`}
size="small"
>
<TestCaseResultIcon testCase={testCase} />
</TableCell>
Expand All @@ -33,6 +34,7 @@ const TestCaseListRow = ({
data-testid={`test-case-name-${testCase.testSuiteIdx}-${testCase.idx}`}
key="test-name-cell"
role="rowcell"
size="small"
>
<Link
to={`/tests/${publicId}/suite/${testCase.testSuiteIdx}/case/${testCase.idx}/`}
Expand All @@ -47,6 +49,7 @@ const TestCaseListRow = ({
key="test-duration-cell"
role="rowcell"
data-testid={`test-case-duration-${testCase.testSuiteIdx}-${testCase.idx}`}
size="small"
>
{testCase.duration}s
</TableCell>
Expand Down
15 changes: 9 additions & 6 deletions ui/src/TestSuite/TestSuiteList.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -28,19 +28,22 @@ const TestSuiteList = ({ publicId, testSuites }: TestSuiteListProps) => {
<TableBody>
{testSuites.map(testSuite => (
<TableRow key={`test-stuite-${testSuite.idx}`}>
<TableCell data-testid={`test-suite-class-name-${testSuite.idx}`}>
<TableCell
data-testid={`test-suite-class-name-${testSuite.idx}`}
size="small"
>
<Link to={`/tests/${publicId}/suite/${testSuite.idx}/`}>
{testSuite.packageName != null
? `${testSuite.packageName}.`
: null}
{testSuite.className}
</Link>
</TableCell>
<TableCell>{testSuite.testCount}</TableCell>
<TableCell>{testSuite.passingCount}</TableCell>
<TableCell>{testSuite.failureCount}</TableCell>
<TableCell>{testSuite.skippedCount}</TableCell>
<TableCell>{testSuite.duration}</TableCell>
<TableCell size="small">{testSuite.testCount}</TableCell>
<TableCell size="small">{testSuite.passingCount}</TableCell>
<TableCell size="small">{testSuite.failureCount}</TableCell>
<TableCell size="small">{testSuite.skippedCount}</TableCell>
<TableCell size="small">{testSuite.duration}</TableCell>
</TableRow>
))}
</TableBody>
Expand Down

0 comments on commit f54b90c

Please sign in to comment.