Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Making projects private or public #521

Merged
merged 1 commit into from
Jul 22, 2024
Merged

Making projects private or public #521

merged 1 commit into from
Jul 22, 2024

Conversation

LanternNassi
Copy link
Contributor

Description

This is to make projects public or private

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

Trello Ticket ID

https://app.clickup.com/t/869515w0j

@LanternNassi LanternNassi requested review from Mubangizi and removed request for Mubangizi July 18, 2024 11:16
Mubangizi
Mubangizi reviewed Jul 19, 2024
View reviewed changes
Copy link
Collaborator

@Mubangizi Mubangizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great @LanternNassi, please also limit private projects from being seen in activity feed by other users.

Mubangizi
Mubangizi reviewed Jul 19, 2024
View reviewed changes
Copy link
Collaborator

@Mubangizi Mubangizi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also a small thing, please add the is_public field in the api_docs.yml file

@LanternNassi
Copy link
Contributor Author

Also a small thing, please add the is_public field in the api_docs.yml file

This is there @Mubangizi

@Mubangizi
Copy link
Collaborator

Also a small thing, please add the is_public field in the api_docs.yml file

This is there @Mubangizi

Not really, please check and verify in the file

@Mubangizi Mubangizi merged commit e8fb586 into microservice Jul 22, 2024
6 checks passed
@Mubangizi Mubangizi deleted the projects_private_public branch July 22, 2024 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mubangizi Mubangizi Mubangizi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LanternNassi @Mubangizi