Merge pull request #13 from crash1115/dev

v0.3.2

README.md

@@ -44,8 +44,11 @@ Sometimes we forget things. Sometimes we mess up. Version 0.3.0 of the module ad
 [![Image from Gyazo](https://i.gyazo.com/5fa7f966fd12c3ad321bb2bf4359be55.png)](https://gyazo.com/5fa7f966fd12c3ad321bb2bf4359be55)
 
 ## Localization (v0.3.0+)
-This module includes support for localization. If you'd like to contribute, please get in touch with me on Discord, or add an issue to the repo. Currently supported languages are:
+This module includes support for localization. Currently supported languages are:
 - English
+- Korean
+
+If you'd like to contribute, please get in touch with me or create a pull request with your translations. For existing translations, new keys may get added as the module is update. If this is the case, you'll be able to find a .json file with all the newly added, untranslated keys in the `lang/missing` directory.
 
 ## Compatibility
 ### Supported Modules
@@ -61,6 +64,7 @@ Contact me on Discord (CRASH1115#2944) to chat, or create an issue right here on
 
 ## Attributions and Special Thanks
 - Thanks to platypus_pi for help with English localization
+- Thanks to KLO#1490 for Korean localization
 
 ## License
 - This work is licensed under a [Creative Commons Attribution 4.0 International License](https://creativecommons.org/licenses/by/4.0/legalcode).

changelog.md

@@ -1,8 +1,20 @@
 # Change Log
 
+## Version 0.3.2
+Improvements:
+- Increased width of progress adjustment column to allow for larger values
+- Updated styling for the activity completion notifications
+- Korean language translation, courtesy of KLO#1490
+
+Removed:
+- The toggle for the Tidy5e delete lock. Deleing downtime items requires confirmation already. Essentially asking for it twice was needlessly annoying for some folks.
+
+Fixes:
+- Fixed some styling for the item control buttons
+
 ## Version 0.3.1
 Fixes:
-- Fixed an issue where enabling MQoL's Item Delete Check setting prevented downtime activities from being deleted on some character sheets. 
+- Fixed an issue where enabling MQoL's Item Delete Check setting prevented downtime activities from being deleted on some character sheets.
 
 ## Version 0.3.0
 New Features:

lang/en.json

@@ -1,13 +1,23 @@
 
 {
+  "C5ETRAINING.AbilityCha": "Charisma",
+  "C5ETRAINING.AbilityCheck": "Ability Check",
+  "C5ETRAINING.AbilityCon": "Constitution",
+  "C5ETRAINING.AbilityDex": "Dexterity",
+  "C5ETRAINING.AbilityInt": "Intelligence",
+  "C5ETRAINING.AbilityStr": "Strength",
+  "C5ETRAINING.AbilityWis": "Wisdom",
   "C5ETRAINING.Action": "Action",
 	"C5ETRAINING.Activity": "Activity",
 	"C5ETRAINING.ActivityProgress": "Activity Progress",
+  "C5ETRAINING.Add": "Add",
+  "C5ETRAINING.Advantage": "Advantage",
 	"C5ETRAINING.AdjustProgressValue": "Adjust Progress",
 	"C5ETRAINING.AdvanceActivityProgress": "Advance Activity Progress",
 	"C5ETRAINING.AnnounceActivityCompletionFor": "Announce Activity Completion For:",
 	"C5ETRAINING.AnnounceActivityCompletionForHint": "Choose which actor types you would like to have trigger chat messages upon activity completion.",
 	"C5ETRAINING.Apply": "Apply",
+  "C5ETRAINING.AttemptsToComplete": "Attempts to complete",
 	"C5ETRAINING.AuditLog": "Change Log",
   "C5ETRAINING.AuditLogDeleteNote": "Note: Dismissing changes does NOT revert them. If you'd like to revert changes you see here, you must do so manually, but this log can serve as a guide to help you figure out what changes to make if required.",
 	"C5ETRAINING.AuditLogInstructionsGm": "This log shows a list of all changes made to the progress of each of this character's downtime activities. You may remove items from this list after you've reviewed them by checking the box in the Dismiss column and hitting the button at the bottom of the window. Once you do this, neither you nor the player will be able to see them anymore.",
@@ -16,6 +26,7 @@
 	"C5ETRAINING.Cancel": "Cancel",
 	"C5ETRAINING.Completed": "completed",
 	"C5ETRAINING.CompletedADowntimeActivity": "completed a downtime activity.",
+  "C5ETRAINING.CompletionTarget": "Completion Target",
 	"C5ETRAINING.Create": "Create",
 	"C5ETRAINING.CreateNewDowntimeActivity": "Create New Downtime Activity",
 	"C5ETRAINING.CurrentProgress": "Current Progress",
@@ -31,6 +42,7 @@
 	"C5ETRAINING.Delete": "Delete",
 	"C5ETRAINING.DeleteConfirmation": "Are you sure you want to delete this item?",
 	"C5ETRAINING.DeleteDowntimeActivity": "Delete Downtime Activity",
+  "C5ETRAINING.Disadvantage": "Disadvantage",
 	"C5ETRAINING.Dismiss": "Dismiss",
   "C5ETRAINING.DismissSelected": "Dismiss Selected",
 	"C5ETRAINING.DowntimeActivityComplete": "Downtime Activity Complete",
@@ -46,6 +58,8 @@
 
 	"C5ETRAINING.Name": "Name",
 	"C5ETRAINING.NewDowntimeActivity": "New Downtime Activity",
+  "C5ETRAINING.None": "None",
+  "C5ETRAINING.Normal": "Normal",
 	"C5ETRAINING.NpcsOnly": "NPC's Only",
 
 	"C5ETRAINING.PcsAndNpcs": "PC's and NPC's",
@@ -55,6 +69,7 @@
 
   "C5ETRAINING.ReviewChanges": "Review Changes",
 
+  "C5ETRAINING.SelectAnAbility": "Select an ability to use for progression",
 	"C5ETRAINING.ShowDowntimeTab": "Show Downtime Tab",
 	"C5ETRAINING.ShowDowntimeTabHint": "Toggling this on will display the training tab on all player character sheets. You will need to close and reopen sheets for this to take effect.",
 	"C5ETRAINING.Simple": "Simple",

lang/ko.json

@@ -0,0 +1,65 @@
+
+{
+  "C5ETRAINING.Action": "액션",
+	"C5ETRAINING.Activity": "활동",
+	"C5ETRAINING.ActivityProgress": "활동 진행률",
+	"C5ETRAINING.AdjustProgressValue": "진행률 조정",
+	"C5ETRAINING.AdvanceActivityProgress": "고급 활동 진행률",
+	"C5ETRAINING.AnnounceActivityCompletionFor": "활동 완료 알림 : ",
+	"C5ETRAINING.AnnounceActivityCompletionForHint": "활동 완료 시 채팅 메시지를 작동 시킬 액터 유형을 선택한다",
+	"C5ETRAINING.Apply": "적용",
+	"C5ETRAINING.AuditLog": "기록 변경",
+  "C5ETRAINING.AuditLogDeleteNote": "참고:변경을 취소해도 변경사항은 복구되지 않는다. 여기에 표시된 변경사항을 되돌리려면 수동으로 변경해야 하지만 기록을 사용하여 변경사항을 파악하는데 도움을 줄 수 있다.",
+	"C5ETRAINING.AuditLogInstructionsGm": "이 기록은 이 캐릭터의 여가 활동의 진행 상황에 대한 모든 변경 내역을 보여준다. 취소 열의 상자를 선택하고 창 하단의 버튼을 눌러 확인 후 항목을 제거할 수 있다. 이렇게 할 경우 다시 볼 수 없다.",
+  "C5ETRAINING.AuditLogInstructionsPlayer": "이 기록은 GM이 아직 확인하지 않은 각 여가 활동의 진행률에 대한 변경사항 목록을 보여준다. 확인 될 경우 더 이상 보이지 않게 된다.",
+
+	"C5ETRAINING.Cancel": "취소",
+	"C5ETRAINING.Completed": "완료 :",
+	"C5ETRAINING.CompletedADowntimeActivity": "완료된 여가 활동",
+	"C5ETRAINING.Create": "생성",
+	"C5ETRAINING.CreateNewDowntimeActivity": "새 여가 활동 생성",
+	"C5ETRAINING.CurrentProgress": "현재 진행률",
+
+	"C5ETRAINING.DefaultAbility": "능력 판정 진행에 대한 기본 속성",
+	"C5ETRAINING.DefaultAbilityHint": "생성시 여가 활동에 할당된 기본 속성을 설정한다. 생성 후 편집할 수 있다.",
+	"C5ETRAINING.DefaultAbilityCompletion": "기본 활동 달성 목표 (능력 판정)",
+	"C5ETRAINING.DefaultAbilityCompletionHint": "능력 판정 진행을 통한 여가 활동의 100% 완료에 필요한 기본 목표 수를 설정한다. 경험에 비추어 볼 때 평균적 개인은 활동 진행을 위해 판정 당 전체 점수에 10점 정도를 기여할 수 있다. 기본값은 300(또는 일별 평균 개인 훈련의 경우 30일)이다.",
+	"C5ETRAINING.DefaultSimpleCompletion": "기본 활동 완료 목표 (심플)",
+	"C5ETRAINING.DefaultSimpleCompletionHint": "심플 진행을 통한 여가 활동에 대해 100% 완료에 필요한 기본 목표 시도 횟수를 설정한다. 기본값은 10이다.",
+	"C5ETRAINING.DefaultTimeCompletion": "기본 활동 완료 목표 (시간)",
+	"C5ETRAINING.DefaultTimeCompletionHint": "시간 기반 진행을 이용한 여가 활동의 100% 완료에 필요한 기본 목표 일수를 설정한다. 기본값은 30일(About Time 모듈 필요)",
+	"C5ETRAINING.Delete": "삭제",
+	"C5ETRAINING.DeleteConfirmation": "이 항목을 정말로 삭제하시겠습니까?",
+	"C5ETRAINING.DeleteDowntimeActivity": "여가 활동 삭제",
+	"C5ETRAINING.Dismiss": "삭제",
+  "C5ETRAINING.DismissSelected": "선택 대상 삭제",
+	"C5ETRAINING.DowntimeActivityComplete": "여가 활동 완료",
+	"C5ETRAINING.DowntimeTabName": "여가시간 탭 이름",
+	"C5ETRAINING.DowntimeTabNameHint": "훈련 탭의 제목을 여기에 입력하여 설정한다. 기본 값은 'Downtime'이지만 모듈을 어떻게 사용하는지에 따라 다른 이름으로 부를 수도 있다.",
+
+	"C5ETRAINING.Edit": "수정",
+	"C5ETRAINING.EditDowntimeActivity": "여가 활동 수정",
+	"C5ETRAINING.EnableDowntimeReminders": "여가시간 확인 활성화",
+	"C5ETRAINING.EnableDowntimeRemindersHint": "이것을 활성화 하면 매일의 시작 시 GM에게 메시지를 표시하여 플레이어에게 진행하고자 하는 여가 활동이 있는지 물어보는 것을 잊지 않도록 할 수 있다.(About Time 모듈 필요)",
+
+	"C5ETRAINING.InvalidNumberWarning": "잘못된 입력. 숫자를 입력하십시오.",
+
+	"C5ETRAINING.Name": "이름",
+	"C5ETRAINING.NewDowntimeActivity": "새 여가 활동",
+	"C5ETRAINING.NpcsOnly": "NPC만",
+
+	"C5ETRAINING.PcsAndNpcs": "PC와 NPC",
+	"C5ETRAINING.PcsOnly": "PC만",
+	"C5ETRAINING.ProgressChange": "진행률 변경",
+	"C5ETRAINING.ProgressionType": "진행 유형",
+
+  "C5ETRAINING.ReviewChanges": "변경 내용 확인",
+
+	"C5ETRAINING.ShowDowntimeTab": "여가시간 탭 표시",
+	"C5ETRAINING.ShowDowntimeTabHint": "이것을 활성화 하면 모든 플레이어 시트에 훈련 탭이 표시된다. 이를 적용하려면 시트를 다시 열어야 한다.",
+	"C5ETRAINING.Simple": "심플",
+
+	"C5ETRAINING.Time": "시간 (UTC)",
+
+  "C5ETRAINING.User": "유저"
+}

lang/missing/en.json

@@ -0,0 +1,4 @@
+
+{
+
+}

lang/missing/ko.json

@@ -0,0 +1,22 @@
+
+{
+  "C5ETRAINING.AbilityCha": "Charisma",
+  "C5ETRAINING.AbilityCheck": "Ability Check",
+  "C5ETRAINING.AbilityCon": "Constitution",
+  "C5ETRAINING.AbilityDex": "Dexterity",
+  "C5ETRAINING.AbilityInt": "Intelligence",
+  "C5ETRAINING.AbilityStr": "Strength",
+  "C5ETRAINING.AbilityWis": "Wisdom",
+  "C5ETRAINING.Add": "Add",
+  "C5ETRAINING.Advantage": "Advantage",
+  "C5ETRAINING.AttemptsToComplete": "Attempts to complete",
+
+  "C5ETRAINING.CompletionTarget": "Completion Target",
+
+  "C5ETRAINING.Disadvantage": "Disadvantage",
+
+  "C5ETRAINING.None": "None",
+  "C5ETRAINING.Normal": "Normal",
+
+  "C5ETRAINING.SelectAnAbility": "Select an ability to use for progression",
+}

module.json

@@ -2,10 +2,10 @@
 	"name": "5e-training",
 	"title": "Crash's 5e Downtime Tracking",
 	"description": "Adds a section to the character sheet to keep track of downtime activity progression. Track proficiency training, spell scribing, and anything else you can think of.",
-	"version": "0.3.1",
+	"version": "0.3.2",
 	"author": "CRASH1115#2944",
 	"minimumCoreVersion": "0.6.0",
-	"compatibleCoreVersion": "0.6.4",
+	"compatibleCoreVersion": "0.6.5",
 	"systems": ["dnd5e"],
 	"esmodules": ["training.js"],
 	"styles": ["styles/training.css"],
@@ -14,9 +14,14 @@
 			"lang": "en",
 			"name": "English",
 			"path": "lang/en.json"
+		},
+		{
+			"lang": "ko",
+			"name": "Korean",
+			"path": "lang/ko.json"
 		}
 	],
 	"url": "https://github.com/crash1115/5e-training",
   "manifest": "https://raw.githubusercontent.com/crash1115/5e-training/master/module.json",
-	"download": "https://github.com/crash1115/5e-training/releases/download/v0.3.1/5e-training.zip"
+	"download": "https://github.com/crash1115/5e-training/releases/download/v0.3.2/5e-training.zip"
 }

styles/training.css

@@ -16,10 +16,15 @@
 }
 
 /* Type Column */
-.training .item-detail {
+.training .item-detail.type {
 	text-transform: capitalize;
 }
 
+/* Override Column */
+.dnd5e.sheet.actor .training .inventory-list .item-detail.override {
+	flex: 0 0 90px;
+}
+
 /* Progress Columns */
 .training .item-detail.bar {
 	flex: 1 !important;
@@ -31,7 +36,7 @@
   padding-top: 1px;
   line-height: 1;
 	display: inline;
-  max-width: 30px;
+  max-width: 40px;
 }
 
 /* Training Bar */
@@ -139,16 +144,6 @@
 /*     SUPPORT FOR TIDY 5E     */
 /*****************************/
 
-/* Hide the lock by default */
-.training .tidy5e-delete-lock {
-	display: none;
-}
-
-/* Show the lock when tidy is active*/
-.tidy5e.sheet.actor .training .tidy5e-delete-lock {
-	display: inline-block;
-}
-
 .tidy5e .training .item-controls .item-create {
 	padding-left: 5px;
 	padding-right: 5px;
@@ -169,6 +164,10 @@
 	line-height: 30px;
 }
 
+.tidy5e.sheet.actor.npc .training .inventory-list .item-detail .training-override {
+	max-width: 40px;
+}
+
 .tidy5e.sheet.actor.npc .training .inventory-list .inventory-header .item-controls a.item-create {
 	margin-top: 0px;
 	padding: 4px 5px;

templates/add-training-dialog.html

@@ -7,7 +7,7 @@
   <div class="field">
     <label for="progressionStyle">{{ localize "C5ETRAINING.ProgressionType" }}:</label>
       <select name="progressionStyleInput" id="progressionStyleInput">
-      <option value="ability" {{#if (eq training.progressionStyle "ability")}} selected {{/if}}>{{ localize "DND5E.ActionAbil" }}</option>
+      <option value="ability" {{#if (eq training.progressionStyle "ability")}} selected {{/if}}>{{ localize "C5ETRAINING.AbilityCheck" }}</option>
       <option value="simple" {{#if (eq training.progressionStyle "simple")}} selected {{/if}}>{{ localize "C5ETRAINING.Simple" }}</option>
     </select>
   </div>

templates/completion-message.html

@@ -0,0 +1,14 @@
+<div class="dnd5e chat-card item-card">
+    <header class="card-header flexrow">
+        <h3 class="item-name">{{ localize "C5ETRAINING.DowntimeActivityComplete" }}</h3>
+    </header>
+
+    <div class="card-content">
+      {{actor.name}} {{ localize "C5ETRAINING.Completed" }} {{activity.name}}!
+    </div>
+
+
+    <footer class="card-footer">
+      <span>Crash's 5e Downtime Tracker</span>
+    </footer>
+</div>

templates/partials/ability.html

@@ -1,16 +1,16 @@
 <div class="field">
-  <label for="ability">Select an ability to use for progression:</label>
+  <label for="ability">{{ localize 'C5ETRAINING.SelectAnAbility' }}:</label>
   <select name="abilityInput" id="abilityInput"" {{#if (eq training.progressionStyle "simple")}}style="visibility:hidden;"{{/if}}>
-    <option value="str" {{#if (eq training.ability "str")}} selected {{/if}}>Strength</option>
-    <option value="dex" {{#if (eq training.ability "dex")}} selected {{/if}}>Dexterity</option>
-    <option value="con" {{#if (eq training.ability "con")}} selected {{/if}}>Constitution</option>
-    <option value="int" {{#if (eq training.ability "int")}} selected {{/if}}>Intelligence</option>
-    <option value="wis" {{#if (eq training.ability "wis")}} selected {{/if}}>Wisdom</option>
-    <option value="cha" {{#if (eq training.ability "cha")}} selected {{/if}}>Charisma</option>
+    <option value="str" {{#if (eq training.ability "str")}} selected {{/if}}>{{ localize 'C5ETRAINING.AbilityStr' }}</option>
+    <option value="dex" {{#if (eq training.ability "dex")}} selected {{/if}}>{{ localize 'C5ETRAINING.AbilityDex' }}</option>
+    <option value="con" {{#if (eq training.ability "con")}} selected {{/if}}>{{ localize 'C5ETRAINING.AbilityCon' }}</option>
+    <option value="int" {{#if (eq training.ability "int")}} selected {{/if}}>{{ localize 'C5ETRAINING.AbilityInt' }}</option>
+    <option value="wis" {{#if (eq training.ability "wis")}} selected {{/if}}>{{ localize 'C5ETRAINING.AbilityWis' }}</option>
+    <option value="cha" {{#if (eq training.ability "cha")}} selected {{/if}}>{{ localize 'C5ETRAINING.AbilityCha' }}</option>
   </select>
 </div>
 
 <div class="field">
-  <label for="completionAt">Completion Target:</label>
+  <label for="completionAt">{{ localize 'C5ETRAINING.CompletionTarget' }}:</label>
   <input type="text" name="completionAtInput" id="completionAtInput" value="{{training.completionAt}}">
 </div>

templates/partials/simple.html

@@ -1,4 +1,4 @@
 <div class="field">
-  <label for="completionAt">Attempts to complete:</label>
+  <label for="completionAt">{{ localize 'C5ETRAINING.AttemptsToComplete' }}:</label>
   <input type="text" name="completionAtInput" id="completionAtInput" value="{{training.completionAt}}">
 </div>

templates/training-section.html

@@ -3,17 +3,11 @@
     <li class="inventory-header flexrow">
       <h3 class="item-name flexrow">{{ localize 'C5ETRAINING.ActivityProgress' }}</h3>
       <div class="item-controls">
-        <a class="tidy5e-delete-lock">
-          <label for="tidy5e-allow-delete" class="tidy5e-delete-toggle">
-            <span class="tidy5e-delete-disabled" title="{{ localize 'TIDY5E.DeleteDisabledHint' }}"><i class="fas fa-lock"></i>{{ localize 'TIDY5E.DeleteDisabled' }}</span>
-            <span class="tidy5e-delete-enabled" title="{{ localize 'TIDY5E.DeleteEnabledHint' }}"><i class="fas fa-unlock"></i>{{ localize 'TIDY5E.DeleteEnabled' }}</span>
-          </label>
-        </a>
         <a class="item-control item-create training-audit" title="{{ localize 'C5ETRAINING.ReviewChanges' }}">
           <i class="fas fa-clipboard"></i> {{ localize 'C5ETRAINING.AuditLog' }}
         </a>
         <a class="item-control item-create training-add" title="{{ localize 'C5ETRAINING.CreateNewDowntimeActivity' }}">
-          <i class="fas fa-plus-circle"></i> {{ localize 'DND5E.Add' }}
+          <i class="fas fa-plus-circle"></i> {{ localize 'C5ETRAINING.Add' }}
         </a>
       </div>
     </li>
@@ -24,10 +18,10 @@ <h3 class="item-name flexrow">{{ localize 'C5ETRAINING.ActivityProgress' }}</h3>
             <div class="item-image" style="background-image: url(icons/svg/d20.svg);"></div>
             <h4>{{training.name}}</h4>
           </div>
-          <div class="item-detail">
+          <div class="item-detail type">
             {{training.progressionStyle}} {{#if (eq training.progressionStyle "ability")}}({{training.ability}}){{/if}}
           </div>
-          <div class="item-detail">
+          <div class="item-detail override">
             <input type="text" class="item-control training-override" id="override-{{tid}}" title="{{ localize 'C5ETRAINING.AdjustProgressValue' }}" value="{{training.progress}}"/>
             <span> / {{training.completionAt}}</span>
           </div>