Types: Accept marshalling datetime.date values on DateTime fields
#25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amotl
force-pushed
the
amo/timezone-aware
branch
from
2eca67a to
4fb90ac
Compare
amotl
force-pushed
the
amo/datetime-date
branch
2 times, most recently
from
5ed7b73 to
ca58576
Compare
amotl
force-pushed
the
amo/timezone-aware
branch
from
4fb90ac to
347f2a7
Compare
matriv
reviewed
Jun 24, 2024
amotl
force-pushed
the
amo/timezone-aware
branch
2 times, most recently
from
c7212b2 to
833328b
Compare
3 tasks
amotl
force-pushed
the
amo/timezone-aware
branch
from
833328b to
f52cd8c
Compare
surister
approved these changes
Jun 24, 2024
amotl
force-pushed
the
amo/timezone-aware
branch
from
4482076 to
009d233
Compare
seut
approved these changes
Jun 25, 2024
amotl
force-pushed
the
amo/timezone-aware
branch
from
009d233 to
619c991
Compare
amotl
force-pushed
the
amo/datetime-date
branch
2 times, most recently
from
9508272 to
bd7a00e
Compare
The test suite of `meltano-tap-cratedb`, derived from the corresponding PostgreSQL adapter, will supply `dt.date` objects. Without this patch, those will otherwise fail on this routine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About
The test suite of
meltano-tap-cratedb, derived from the corresponding PostgreSQL adapter, will supplydt.dateobjects. Without this patch, those will otherwise fail on this routine.References
DateTimefields #22Backlog