Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Bump github/codeql-action from 2 to 3" #32

Merged
merged 2 commits into from
Jan 24, 2024
Merged

Conversation

amotl
Copy link
Member

@amotl amotl commented Jan 24, 2024

About

This reverts commit 2cc9147.
CodeQL checks started failing 1, maybe because of GH-2?

Footnotes

  1. https://github.com/crate-workbench/sqlalchemy-cratedb/actions/runs/7615862437/job/20828562756?pr=30

amotl added 2 commits January 24, 2024 19:13
SetuptoolsDeprecationWarning: setup.py install is deprecated. Use build
and pip and other standards-based tools.

It also refers to:

  /usr/local/lib/python3.10/dist-packages/

=> Maybe explicitly installing Python 3.11 helps already?
@amotl amotl marked this pull request as ready for review January 24, 2024 18:24
@amotl amotl merged commit 8bf1838 into main Jan 24, 2024
24 checks passed
@amotl amotl deleted the amo/fix-codeql branch January 24, 2024 18:24
@amotl
Copy link
Member Author

amotl commented Jan 29, 2024

Adding a Python installation through 17aae7c was probably needed because of this change by GitHub.

https://github.blog/changelog/2024-01-23-codeql-2-16-python-dependency-installation-disabled-new-queries-and-bug-fixes/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant