-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Have provided pagination for the case table #242
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please ensure this pull request (PR) branch (ewebbunivAdmin:Dan-Dev
) is up-to-date with the main
branch of creativecommons/legaldb
.
Please update so that filters are maintained when you navigate to different pages.
@TimidRobot I think have updated on how you recommended |
@webbunivAdmin nice job you have there please could you include the name of the issue author also I suggest you work on the table styling to most especially when it comes to the years table row the table head should align with the table data. also, to better test how the table is going to look I prefer you use the Creative Commons license names so you know how the fields are going to look like. Also, work on the responsiveness of the table because I remember when working on the card case it was not responsive |
This is still an issue, but I'm not sure how it can be resolved until there's data to test with: |
The repository now has development data. Please load it and confirm that pagination works correctly with filters. |
Tests ✅Command: ./bin/test.sh Output:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Every page action (changing tags, keyword, or page) needs to maintain all of the state parameters:
direction=
keywords=
page=
sort=
tags[]=
Fixes
Description
Technical details
Tests
Screenshots
Checklist
Update index.md
).main
ormaster
).visible errors.
Developer Certificate of Origin
For the purposes of this DCO, "license" is equivalent to "license or public domain dedication," and "open source license" is equivalent to "open content license or public domain dedication."
Developer Certificate of Origin