Fix issue #23.

ifxConvertNodeConst() calls varcharin() directly, but misunderstood the function call conventions of varcharin() which wants to have three arguments. So instead of DirectFunctionCall2() use DirectFunctionCall3() and pass InvalidOid as the second type OID parameter. See also issue #23 for details. Reported by github user novakka4096.
credativ · Oct 1, 2018 · e7b2d41 · e7b2d41
1 parent 857e183
commit e7b2d41
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/ifx_conv.c b/ifx_conv.c
@@ -2328,8 +2328,9 @@ static Const *ifxConvertNodeConst(Const *oldNode, bool *converted,
 			if (oldNode->constisnull)
 				datVal= PointerGetDatum(NULL);
 		else
-				datVal = DirectFunctionCall2(varcharin,
+				datVal = DirectFunctionCall3(varcharin,
 											 CStringGetDatum(TextDatumGetCString(oldNode->constvalue)),
+											 InvalidOid,
 											 oldNode->consttypmod);
 
 			newNode = makeConst(VARCHAROID,
@@ -2360,8 +2361,9 @@ static Const *ifxConvertNodeConst(Const *oldNode, bool *converted,
 			if (oldNode->constisnull)
 				datVal = PointerGetDatum(NULL);
 			else
-				datVal = DirectFunctionCall2(varcharin,
+				datVal = DirectFunctionCall3(varcharin,
 											 CStringGetDatum(text_to_cstring(DatumGetTextP(oldNode->constvalue))),
+											 InvalidOid,
 											 oldNode->consttypmod);
 
 			if (oldNode->consttypmod == -1)