Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: externalize env #163

Merged
merged 12 commits into from
Aug 13, 2024
Merged

feat: externalize env #163

merged 12 commits into from
Aug 13, 2024

Conversation

GHkrishna
Copy link
Contributor

@GHkrishna GHkrishna commented Aug 1, 2024

What

  • externalise ENV

Why

  • avoid hardcoded values

Signed-off-by: Krishna Waske <krishna.waske@ayanworks.com>
Signed-off-by: Krishna Waske <krishna.waske@ayanworks.com>
Signed-off-by: Krishna Waske <krishna.waske@ayanworks.com>
Signed-off-by: Krishna Waske <krishna.waske@ayanworks.com>
Signed-off-by: Krishna Waske <krishna.waske@ayanworks.com>
Signed-off-by: Krishna Waske <krishna.waske@ayanworks.com>
Signed-off-by: Krishna Waske <krishna.waske@ayanworks.com>
Signed-off-by: Krishna Waske <krishna.waske@ayanworks.com>
Signed-off-by: Krishna Waske <krishna.waske@ayanworks.com>
Signed-off-by: Krishna Waske <krishna.waske@ayanworks.com>
Signed-off-by: Krishna Waske <krishna.waske@ayanworks.com>
@GHkrishna GHkrishna changed the title Feat/externalize env feat: externalize env Aug 13, 2024
@GHkrishna GHkrishna self-assigned this Aug 13, 2024
@GHkrishna GHkrishna added the enhancement New feature or request label Aug 13, 2024
@GHkrishna GHkrishna marked this pull request as ready for review August 13, 2024 10:02
Copy link

sonarcloud bot commented Aug 13, 2024

@GHkrishna GHkrishna merged commit f8edf32 into develop Aug 13, 2024
2 checks passed
@GHkrishna GHkrishna linked an issue Aug 30, 2024 that may be closed by this pull request
@GHkrishna GHkrishna deleted the feat/externalize-env branch September 4, 2024 05:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Externalise .env of agent (credo-controller)
2 participants