Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Idiomatic error handling #43

Merged
merged 1 commit into from
Mar 28, 2024
Merged

Idiomatic error handling #43

merged 1 commit into from
Mar 28, 2024

Conversation

tmzane
Copy link
Collaborator

@tmzane tmzane commented Mar 28, 2024

Since we don't use fmt for parsing anymore, we can return errors explicitly 👀

cristaloleg
cristaloleg approved these changes Mar 28, 2024
View reviewed changes
Copy link
Member

@cristaloleg cristaloleg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, nice. #41 was a 1st step for that.

@cristaloleg
Copy link
Member

Can you sign the commit? if no, I will change repo settings for a moment.

@tmzane
Copy link
Collaborator Author

tmzane commented Mar 28, 2024

Can you sign the commit?

Not right now, sorry. But you can force merge as the owner.

@cristaloleg cristaloleg merged commit d60dbd1 into cristalhq:main Mar 28, 2024
3 checks passed
@tmzane tmzane deleted the idiomatic-error-handling branch March 28, 2024 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cristaloleg cristaloleg cristaloleg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tmzane @cristaloleg