Clean up code

cristan · Nov 30, 2024 · 3444748 · 3444748
1 parent 792464b
commit 3444748
Show file tree

Hide file tree

Showing 4 changed files with 2 additions and 7 deletions.
diff --git a/app/src/main/java/nl/ovfietsbeschikbaarheid/util/LocationLoader.kt b/app/src/main/java/nl/ovfietsbeschikbaarheid/util/LocationLoader.kt
@@ -20,7 +20,6 @@ class LocationLoader(
 
     @SuppressLint("MissingPermission")
     suspend fun loadCurrentCoordinates(): Coordinates? {
-        // TODO: add delay to test not calling when it is already recently called
         val currentLocationRequest = CurrentLocationRequest.Builder()
             .setDurationMillis(5000)
             .setGranularity(Granularity.GRANULARITY_COARSE)

diff --git a/app/src/main/java/nl/ovfietsbeschikbaarheid/viewmodel/HomeViewModel.kt b/app/src/main/java/nl/ovfietsbeschikbaarheid/viewmodel/HomeViewModel.kt
@@ -233,11 +233,8 @@ class HomeViewModel(
                 }
             } catch (e: CancellationException) {
                 // The job got cancelled. That's fine: the new job will show the user what they want.
-                // TODO: check if this is still needed after the refactoring is complete
             } catch (e: Exception) {
-                Timber.e(e, "fetchLocation: Failed to fetch location ${this@launch}")
-                // TODO: get rid of the printlns and maybe some of the Timbers
-                println("fetchLocation: Failed to fetch location ${this@launch}; $e")
+                Timber.e(e, "fetchLocation: Failed to fetch location")
                 _content.value = HomeContent.NetworkError
             }
         }

diff --git a/app/src/main/res/values/strings.xml b/app/src/main/res/values/strings.xml
@@ -55,7 +55,6 @@
     <string name="open_state_opens_later_at">• Gaat %1$s open om %2$s</string>
     <string name="open_state_closing_soon">Sluit snel</string>
     <string name="open_state_closes_at">• Sluit om %1$s</string>
-    <string name="open">Open</string>
     <string name="open_until">Open tot %1$s</string>
     <string name="open_state_open_247">24/7 open</string>
     <string name="opening_hours_title">Openingstijden</string>

diff --git a/app/src/main/res/xml/data_extraction_rules.xml b/app/src/main/res/xml/data_extraction_rules.xml
@@ -5,7 +5,7 @@
 -->
 <data-extraction-rules>
     <cloud-backup>
-        <!-- TODO: Use <include> and <exclude> to control what is backed up.
+        <!-- 
         <include .../>
         <exclude .../>
         -->