Allow cluster_pack to handle several unzipped pexes in the same directory #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcuquemelle
force-pushed
the
allow_several_zipped_pexes
branch
from
21d0eea
to
5a6df67
Compare
quentin-auge
reviewed
Sep 5, 2024
cluster_pack/packaging.py
Outdated
| if len(pex_files) == 1: | ||
| return pex_files[0] | ||
|
|
||
| pex_file = next((x for x in pex_files if pex_dir.endswith(x.split(".zip")[0])), None) |
There was a problem hiding this comment.
Selecting the first .pex.zip available here, but why the first and not another?
There was a problem hiding this comment.
In fact we select the one that has the same name as pex_dir. I made the assumption it was unique, but it might not be the case actually, as I dont get an exact match, but only a endswith, so we could actually get false matches.
I'll fix this
jcuquemelle
force-pushed
the
allow_several_zipped_pexes
branch
from
5a6df67
to
547acb8
Compare
quentin-auge
approved these changes
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.