Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

List Language Translations API: support new parameters #219

Closed
andrii-bodnar opened this issue Jan 22, 2024 · 3 comments · Fixed by #220
Closed

List Language Translations API: support new parameters #219

andrii-bodnar opened this issue Jan 22, 2024 · 3 comments · Fixed by #220
Assignees
@Riju-bak
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@andrii-bodnar
Copy link
Member

Crowdin has recently added new parameters to the List Language Translations API endpoint:

  • branchId
  • directoryId

These parameters should also be supported in the Crowdin API client. It would also be good to check if other parameters are supported.

References:
@andrii-bodnar andrii-bodnar added enhancement New feature or request good first issue Good for newcomers labels Jan 22, 2024
@Riju-bak
Copy link
Contributor

Hi @andrii-bodnar, can I work on this?

@andrii-bodnar
Copy link
Member Author

Hi @Riju-bak, sure, thank you!

@Riju-bak Riju-bak mentioned this issue Jan 25, 2024
Merged
@Riju-bak
Copy link
Contributor

@andrii-bodnar Here's the PR

@andrii-bodnar andrii-bodnar linked a pull request Jan 25, 2024 that will close this issue
feat(api): ListLanguageTranslationsAPI - branchId and directoryId params #220
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Riju-bak Riju-bak

Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
2 participants
@andrii-bodnar @Riju-bak