Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(api): ListLanguageTranslationsAPI - branchId and directoryId params #220

Conversation

Riju-bak
Copy link
Contributor

Fix for issue #219

Copy link

codecov bot commented Jan 25, 2024

Codecov Report

Attention: 107 lines in your changes are missing coverage. Please review.

Comparison is base (f45d418) 50.38% compared to head (c445d17) 57.69%.
Report is 79 commits behind head on main.

Files Patch % Lines
src/Crowdin.Api/CrowdinApiClient.cs 0.00% 21 Missing ⚠️
...rowdin.Api/Applications/ApplicationsApiExecutor.cs 69.70% 20 Missing ⚠️
...c/Crowdin.Api/ProjectsGroups/FileFormatSettings.cs 0.00% 19 Missing ⚠️
...Crowdin.Api/Tasks/LanguageServiceTaskCreateForm.cs 0.00% 13 Missing ⚠️
...Api/Core/Converters/EmptyArrayAsObjectConverter.cs 50.00% 7 Missing and 1 partial ⚠️
...verters/ProjectStringsExporterSettingsConverter.cs 68.43% 4 Missing and 2 partials ⚠️
...ks/Organization/OrganizationWebhooksApiExecutor.cs 86.49% 5 Missing ⚠️
...in.Api/Core/Converters/DescriptionEnumConverter.cs 0.00% 1 Missing and 1 partial ⚠️
...rowdin.Api/ProjectsGroups/EnterpriseProjectForm.cs 0.00% 2 Missing ⚠️
...rc/Crowdin.Api/SourceStrings/StringBatchOpPatch.cs 91.31% 1 Missing and 1 partial ⚠️
... and 9 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #220      +/-   ##
==========================================
+ Coverage   50.38%   57.69%   +7.31%     
==========================================
  Files         277      334      +57     
  Lines        3688     5121    +1433     
  Branches        0      409     +409     
==========================================
+ Hits         1858     2954    +1096     
- Misses       1830     2135     +305     
- Partials        0       32      +32     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@andrii-bodnar andrii-bodnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Riju-bak thank you!

@andrii-bodnar andrii-bodnar merged commit 486e863 into crowdin:main Jan 25, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

List Language Translations API: support new parameters
2 participants