Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add new updateOption parameter #63

Conversation

jameskim0987
Copy link
Contributor

@jameskim0987 jameskim0987 commented Sep 25, 2024

Resolves #60

Changes made in this PR:

  1. add new field UpdateOption in SourceStringsUploadRequest according to https://support.crowdin.com/developer/api/v2/string-based/#tag/Source-Strings/operation/api.projects.strings.uploads.post. Also added comment for the field outlining the default value and enum values
  2. add validation for UpdateOption. To use this field, the field UpdateStrings must be set to true as a prerequisite
  3. add testcases for invalid and valid cases

@jameskim0987 jameskim0987 marked this pull request as ready for review September 25, 2024 21:07
@jameskim0987
Copy link
Contributor Author

jameskim0987 commented Sep 25, 2024

Hi @andrii-bodnar, this PR is ready for review

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.20%. Comparing base (3ec8c35) to head (e899f78).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #63      +/-   ##
==========================================
+ Coverage   98.20%   98.20%   +0.01%     
==========================================
  Files          66       66              
  Lines        2934     2936       +2     
==========================================
+ Hits         2881     2883       +2     
  Misses         29       29              
  Partials       24       24              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andrii-bodnar andrii-bodnar changed the title feat: [ISSUE-60] add new updateOption parameter feat: add new updateOption parameter Sep 26, 2024
Copy link
Member

@andrii-bodnar andrii-bodnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jameskim0987 thanks a lot for the contribution!

@andrii-bodnar andrii-bodnar merged commit dd37850 into crowdin:main Sep 26, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upload Strings API: add new updateOption parameter
3 participants