Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ml pipeline rewrite #40

Merged
merged 11 commits into from
Jul 30, 2023
Merged

Ml pipeline rewrite #40

merged 11 commits into from
Jul 30, 2023

Conversation

shailx383
Copy link
Contributor

@shailx383 shailx383 commented Jul 28, 2023

  • Please check if the PR fulfills these requirements
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • The code runs on the contributors machine.
  • The code follows the code style guide of this project.
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    refactor
  • What is the current behavior? (You can also link to an open issue here)
    pipeline works with inception resnet
  • What is the new behavior (if this is a feature change)?
    included FaceNet from model.py
  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
    no
  • Other information:

@adityapentyala
Copy link
Contributor

adityapentyala commented Jul 29, 2023

Works when commit 64c5cdf is reverted, with the exception of removing point.data[0].numpy() in favour of point.data.numpy() on line 90. Check if it works after changes. The rest of it works perfectly so I'll push if the change works

Copy link
Contributor

@adityapentyala adityapentyala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also, could you add tqdm to the env file? had to install that but again it might be a problem with only my env

@shailx383
Copy link
Contributor Author

removed tqdm as it is not required

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

line 90 still throws an error when only point.data is written. code runs perfectly with point.data.numpy()

Copy link
Contributor

@adityapentyala adityapentyala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, merging

@adityapentyala adityapentyala merged commit 2d5126e into master Jul 30, 2023
1 check passed
@majimearun majimearun deleted the ml-pipeline-rewrite branch August 17, 2023 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants