Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update: List updated with new participants #716

Merged
merged 6 commits into from
Oct 1, 2023

Conversation

vimode
Copy link
Contributor

@vimode vimode commented Sep 30, 2023

Thanks for contributing to the Hacktoberfest Swag List 😃 🎉! Before submitting your pull request, please check off as many of the items below as you can:

  1. I have read the Contributing.md file and formatted this PR correctly
  2. I'm not adding a company from the blocklist
  3. I make sure to fix things promptly if an error or suggestion comes up

Thanks and Happy Hacktoberfest! 🎉
Tagging @crweiner to take a look. 👀

Happy Hacktoberfest!!! 🎉
Update the list with multiple participants.

Despite being the official sponsor of Hacktoberfest, Illa Cloud also has its own separate hacktoberfest event going on which does give physical swag. For now I added it under I but in my opinion it should be at the top of the list along with DO, as its one of the official sponsors.

Thank you.

docs/list.md Outdated
- **Requirements**: Be the top 3 contributors with most accepts PRs/MRs.
- **How to sign up**: [Hacktoberfest Website](https://hacktoberfest.com).
- **Issues**: All the [open issues]( https://github.com/search?q=org%3AgetAlby+label%3Ahacktoberfest&type=issues&ref=blog.getalby.com).
- **Notes**: Read the [announcement post](Read more here
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lists should be surrounded by blank lines

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@crweiner Sorry but I am unsure of what am I supposed to do here.
There are blank lines surrounding this listing, isn't it?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No worries, @vimode! The issue is that anything in the ( ) for a link has to be a URL. The "Read more here" text isn't a URL, so the Markdown linter flagged it. 🎏 Happy to fix this, and thank you for adding so many new companies to the List!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I see now, the text and formatting is all a wrong for the link. Thank you for fixing it.

@vimode vimode changed the title Update: List update with participants Update: List updated with new participants Sep 30, 2023
@netlify
Copy link

netlify bot commented Sep 30, 2023

Deploy Preview for hacktoberfest-swag-list ready!

Name Link
🔨 Latest commit 4102f73
🔍 Latest deploy log https://app.netlify.com/sites/hacktoberfest-swag-list/deploys/6518efafa10ece000894a87e
😎 Deploy Preview https://deploy-preview-716--hacktoberfest-swag-list.netlify.app/list
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ghost
Copy link

ghost commented Sep 30, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

docs/list.md Outdated Show resolved Hide resolved
@vimode
Copy link
Contributor Author

vimode commented Oct 1, 2023

Hey @crweiner since you haven't merged this one yet, can I add some more to the list instead of creating a new PR?

@codeclimate
Copy link

codeclimate bot commented Oct 1, 2023

Code Climate has analyzed commit 4102f73 and detected 0 issues on this pull request.

View more on Code Climate.

@crweiner
Copy link
Owner

crweiner commented Oct 1, 2023

Hi @vimode! Thank you so very much for your massive contribution to the Hacktoberfest Swag List for 2023! I'm so happy to see you back! I greatly appreciate your time and effort in scouting out what companies are participating in Hacktoberfest for another year!!! 🎉

Hey @crweiner since you haven't merged this one yet, can I add some more to the list instead of creating a new PR?

I'd like to get this merged now so that way the list is more filled out for today (the first day of Hacktoberfest). Please do submit a new PR if you have more companies to add!

Thank you again, and you rock!!

you rock

@crweiner crweiner merged commit aad9a98 into crweiner:master Oct 1, 2023
6 checks passed
@crweiner crweiner added hacktoberfest Contributed in the spirit of Hacktoberfest! hacktoberfest-accepted Approved for Hacktoberfest labels Oct 1, 2023
@vimode vimode deleted the vimode/update_list branch October 1, 2023 04:43
@crweiner
Copy link
Owner

crweiner commented Oct 1, 2023

I realize I never answered this, @vimode:

Despite being the official sponsor of Hacktoberfest, Illa Cloud also has its own separate hacktoberfest event going on which does give physical swag. For now I added it under I but in my opinion it should be at the top of the list along with DO, as its one of the official sponsors.

Thanks for calling that out!I know that Appwrite is having their own Hacktoberfest swag and events as well, and they are also an official sponsor of the entire event again this year.

My thought is to add Illa Cloud and Appwrite listings to the alphabetical section as normal for now, and maybe that's something we may adjust later.

@vimode
Copy link
Contributor Author

vimode commented Oct 1, 2023

My thought is to add Illa Cloud and Appwrite listings to the alphabetical section as normal for now, and maybe that's something we may adjust later.

Thank you @crweiner for addressing that! I agree the sections might look out of place.

Maybe to highlight their (Appwrite & Illa Cloud) events, we could add a mention of it somewhere in The Original listing or just add the anchor link to their names in the title itself?
I think this could be a good balance between highlighting their events and not breaking the current established hierarchy of the list.

Just an idea to mull over.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest Contributed in the spirit of Hacktoberfest! hacktoberfest-accepted Approved for Hacktoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants