Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Tolgee #914

Merged
merged 6 commits into from
Oct 5, 2024
Merged

Add Tolgee #914

merged 6 commits into from
Oct 5, 2024

Conversation

moingshaikh
Copy link
Contributor

@moingshaikh moingshaikh commented Oct 2, 2024

PR for Issue #908 Add Tolgee to the Hacktoberfest Swag List

Thanks for contributing to the Hacktoberfest Swag List 😃 🎉! Before submitting your pull request, please check off as many of the items below as you can:

  1. I have read the Contributing.md file and formatted this PR correctly
  2. I'm not adding a company from the blocklist
  3. I make sure to fix things promptly if an error or suggestion comes up

Thanks and Happy Hacktoberfest! 🎉
Tagging @crweiner to take a look. 👀

PR for Issue crweiner#908 Add Tolgee to the Hacktoberfest Swag List
docs/list.md Outdated Show resolved Hide resolved
Copy link

netlify bot commented Oct 2, 2024

Deploy Preview for hacktoberfest-swag-list ready!

Name Link
🔨 Latest commit 7741192
🔍 Latest deploy log https://app.netlify.com/sites/hacktoberfest-swag-list/deploys/6700ac58458b0f000894c44e
😎 Deploy Preview https://deploy-preview-914--hacktoberfest-swag-list.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@vimode
Copy link
Contributor

vimode commented Oct 2, 2024

Hey @moingshaikh Great job starting this PR! 👏

If you go through the hacktoberfest swag list you will notice all the information is condensed to make it easy and quick to read.

I would recommend you do the same, with your PR. You can edit the Requirements to give a brief overview of what is expected.
If you need help let me know I can suggest some edits.

Good luck!

Made the information in the commit more condensed and easy to read based on the feedback provided.
@moingshaikh
Copy link
Contributor Author

Hey @moingshaikh Great job starting this PR! 👏

If you go through the hacktoberfest swag list you will notice all the information is condensed to make it easy and quick to read.

I would recommend you do the same, with your PR. You can edit the Requirements to give a brief overview of what is expected. If you need help let me know I can suggest some edits.

Good luck!

Thanks for the feedback @vimode,

I have made the edits to make the information more condensed.

@crweiner crweiner changed the title Update list.md Add Tolgee Oct 5, 2024
@crweiner crweiner linked an issue Oct 5, 2024 that may be closed by this pull request
docs/list.md Outdated
@@ -223,6 +223,16 @@ No one currently! Interested in having a prominent placement for your open sourc
- **How to sign up**: No specific signup mentioned. Contribute to participating repos.
- **Notes**: [Checkout their Hacktoberfest Github page for additional info](https://github.com/TBD54566975/developer.tbd.website/issues/1680).


Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Multiple consecutive blank lines

Copy link

codeclimate bot commented Oct 5, 2024

Code Climate has analyzed commit 7741192 and detected 0 issues on this pull request.

View more on Code Climate.

Copy link
Owner

@crweiner crweiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @moingshaikh and @vimode for suggesting and making these changes! Happy to add Tolgee to the Hacktoberfest Swag List!

@crweiner crweiner merged commit c0adb24 into crweiner:master Oct 5, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Tolgee to the Hacktoberfest Swag List
3 participants