feat: Add GetFloatingClientMetadata method #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahmad-kemsan
reviewed
Aug 1, 2024
| GetFloatingClientMetadata.argtypes = [CSTRTYPE, STRTYPE, c_uint32] | ||
| GetFloatingClientMetadata.restype = c_int | ||
|
|
||
|
|
||
| RequestFloatingLicense = library.RequestFloatingLicense |
There was a problem hiding this comment.
@muneebkq Why this extra line?
ahmad-kemsan
reviewed
Aug 1, 2024
|
|
||
| Returns: | ||
| str: value of metadata for the key | ||
| """ |
There was a problem hiding this comment.
@muneebkq Update the docs, it does not return the value of metadata for the key, instead it simply returns value of the floating client metadata
ahmad-kemsan
requested changes
Aug 1, 2024
ahmad-kemsan
reviewed
Aug 6, 2024
| str: value of the floating client metadata | ||
| """ | ||
| cstring_key = LexFloatClientNative.get_ctype_string(key) | ||
| buffer_size = 256 |
There was a problem hiding this comment.
@muneebkq Updated the buffer size to 4096
ahmad-kemsan
approved these changes
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GetFloatingClientMetadata, to retrieve the value of the floating client metadata. The method takes a key as an argument and returns the corresponding value.