Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Muneeb/get floating license mode #11

Merged
merged 6 commits into from
Aug 6, 2024

Conversation

muneebkq
Copy link
Collaborator

add get floating license mode function

@muneebkq muneebkq requested a review from ahmad-kemsan July 16, 2024 08:47
@muneebkq muneebkq changed the base branch from master to borrowing-develop August 1, 2024 04:09
@@ -103,8 +103,7 @@ def SetFloatingClientMetadata(key, value):

@staticmethod
def GetFloatingClientLibraryVersion():
"""Gets the floating client library version.

"""Gets floating client library version.
Raises:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@muneebkq Why was this changed?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

refactored

Copy link
Collaborator

@ahmad-kemsan ahmad-kemsan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check the comment

@muneebkq muneebkq requested a review from ahmad-kemsan August 6, 2024 06:25
@ahmad-kemsan ahmad-kemsan merged commit 38924a9 into borrowing-develop Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants