feat: add status codes #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@muneebkq why are there so many changes to this file? Why was '=' replaced with ':'? |
ahmad-kemsan
requested changes
Aug 1, 2024
|
@muneebkq You seem to have skipped the matching of error code with the lexfloatclient exceptions |
ahmad-kemsan
reviewed
Aug 6, 2024
|
|
||
| LF_E_WMIC = 65 | ||
|
|
||
| LF_E_MACHINE_FINGERPRINT = 66 | ||
|
|
There was a problem hiding this comment.
@muneebkq Please add 67 as well
ahmad-kemsan
reviewed
Aug 6, 2024
| if code == LexFloatStatusCodes.LF_E_WMIC: | ||
| return "Fingerprint couldn't be generated because Windows Management Instrumentation (WMI) service has been disabled. This error is specific to Windows only." | ||
| if code == LexFloatStatusCodes.LF_E_MACHINE_FINGERPRINT: | ||
| return 'Machine fingerprint has changed since activation.' | ||
| return 'Unknown error!' |
There was a problem hiding this comment.
@muneebkq Please add the invalid proxy error code as well
ahmad-kemsan
requested changes
Aug 6, 2024
ahmad-kemsan
approved these changes
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.