Relaxed inUse definition #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
overheadhunter
requested changes
Sep 25, 2023
src/main/java/org/cryptomator/frontend/fuse/OpenFileFactory.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Sebastian Stenzel <overheadhunter@users.noreply.github.com>
overheadhunter
requested changes
Oct 4, 2023
src/main/java/org/cryptomator/frontend/fuse/ReadOnlyAdapter.java
Outdated
Show resolved
Hide resolved
src/main/java/org/cryptomator/frontend/fuse/ReadOnlyAdapter.java
Outdated
Show resolved
Hide resolved
|
Kudos, SonarCloud Quality Gate passed!
|
overheadhunter
approved these changes
Oct 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR also mitigates problems described in #79, but with a different approach. Instead of timing based staleness of opened files, we determine if the filesystem is "in use", if at least one open file exists, which was written to.
The idea behind this approach is to allow regular unmounting as long as no data loss happens on the filesystem. If an open file was written to, we require it to be properly closed by a
release()call to letisInUse()returnfalse.